LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marek Belisko <marek.belisko@open-nandra.com>
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Marek Belisko <marek.belisko@open-nandra.com>
Subject: [PATCH 2/5] staging: ft1000: Remove unnecessary assignment.
Date: Wed, 26 Jan 2011 12:49:12 +0100 [thread overview]
Message-ID: <1296042555-29145-2-git-send-email-marek.belisko@open-nandra.com> (raw)
In-Reply-To: <1296042555-29145-1-git-send-email-marek.belisko@open-nandra.com>
dsp_img_info->version and requested_version have same type
so additional temporary variable creation could be omitted
because variables could be compares directly.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
.../staging/ft1000/ft1000-usb/ft1000_download.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 9e9709a..b99553b 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
@@ -1026,12 +1026,7 @@ u16 scram_dnldr(struct ft1000_device *ft1000dev, void *pFileStart, u32 FileLeng
for (image = 0; image < file_hdr->nDspImages; image++)
{
-
- temp = (u16)(dsp_img_info->version);
- templong = temp;
- temp = (u16)(dsp_img_info->version >> 16);
- templong |= (temp << 16);
- if (templong == (u32)requested_version)
+ if (dsp_img_info->version == requested_version)
{
correct_version = TRUE;
DEBUG("FT1000:download: correct_version is TRUE\n");
--
1.7.1
next prev parent reply other threads:[~2011-01-26 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 11:49 [PATCH 1/5] staging: ft1000: Remove unused variables Marek Belisko
2011-01-26 11:49 ` Marek Belisko [this message]
2011-01-26 11:49 ` [PATCH 3/5] staging: ft1000: Create common function for buffers check Marek Belisko
2011-01-26 11:49 ` [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function Marek Belisko
2011-01-26 13:07 ` Dan Carpenter
2011-01-26 13:34 ` Belisko Marek
2011-01-26 13:43 ` Dan Carpenter
2011-01-26 13:56 ` Belisko Marek
2011-01-26 14:30 ` Dan Carpenter
2011-02-08 13:40 ` Belisko Marek
2011-02-08 16:35 ` Dan Carpenter
2011-02-09 8:27 ` Belisko Marek
2011-02-09 10:07 ` Belisko Marek
2011-02-09 11:08 ` Dan Carpenter
2011-02-09 11:16 ` Belisko Marek
2011-01-26 11:49 ` [PATCH 5/5] staging: ft1000: Fix indentation in scram_dnldr() function Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296042555-29145-2-git-send-email-marek.belisko@open-nandra.com \
--to=marek.belisko@open-nandra.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 2/5] staging: ft1000: Remove unnecessary assignment.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).