LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] checkpatch.pl: be more specific about what is wrong with Kconfig help
@ 2011-01-31 12:00 Tomas Winkler
  2011-02-01  8:31 ` WANG Cong
  0 siblings, 1 reply; 2+ messages in thread
From: Tomas Winkler @ 2011-01-31 12:00 UTC (permalink / raw)
  To: Andy Whitcroft; +Cc: linux-kernel, Tomas Winkler

explain that Kconfig help paragraphs is expected to be at least 4 lines
long

Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 scripts/checkpatch.pl |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4c0383d..679122f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1452,7 +1452,9 @@ sub process {
 				}
 				$length++;
 			}
-			WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_end && $length < 4);
+			if ($is_end && $length < 4) {
+				WARN("please write a paragraph that describes the config symbol fully, at least 4 lines\n" . $herecurr);
+			}
 			#print "is_end<$is_end> length<$length>\n";
 		}
 
-- 
1.7.3.5

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] checkpatch.pl: be more specific about what is wrong with Kconfig help
  2011-01-31 12:00 [PATCH] checkpatch.pl: be more specific about what is wrong with Kconfig help Tomas Winkler
@ 2011-02-01  8:31 ` WANG Cong
  0 siblings, 0 replies; 2+ messages in thread
From: WANG Cong @ 2011-02-01  8:31 UTC (permalink / raw)
  To: linux-kernel

On Mon, 31 Jan 2011 14:00:51 +0200, Tomas Winkler wrote:

> explain that Kconfig help paragraphs is expected to be at least 4 lines
> long
> 

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-01  8:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-31 12:00 [PATCH] checkpatch.pl: be more specific about what is wrong with Kconfig help Tomas Winkler
2011-02-01  8:31 ` WANG Cong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).