LKML Archive on
help / color / mirror / Atom feed
From: Dave Hansen <>
To: Steffen Klassert <>
Cc: Andrew Morton <>,
	Eric Paris <>,,
Subject: Re: [PATCH] flex_array: Change behaviour on zero size allocations
Date: Tue, 01 Feb 2011 06:55:45 -0800	[thread overview]
Message-ID: <1296572145.27022.2837.camel@nimitz> (raw)
In-Reply-To: <>

On Tue, 2011-02-01 at 12:03 +0100, Steffen Klassert wrote:
> rc = flex_array_prealloc(p->type_val_to_struct_array, 0,
>                          p->p_types.nprim - 1, GFP_KERNEL | __GFP_ZERO);
> if (rc)
>         goto out;
> If p->p_types.nprim is zero, we allocare with total_nr_elements equal
> to zerro and then we try to prealloc with p->p_types.nprim - 1.
> flex_array_prealloc interprets this as an unsigned int and fails,
> because this is bigger than total_nr_elements, which is correct I
> think.
> Thoughts?

The most we ever hold in a flex_array is ~2 million entries.  So we have
plenty of room to use a normal int if you want.

On the other hand, there's only one user of flex_array_prealloc(), and
making the "end" argument inclusive doesn't seem to be what that user
wants.  We might want to either make flex_array_prealloc() take start
and length, or instead make "end" be exclusive of the "end" index.

I thought that flex_array_prealloc would say, effectively: "all put()'s
would work up until 'end'".  But, looking at it now, that's probably not
how people will use it.  

-- Dave

  reply	other threads:[~2011-02-01 14:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31  8:52 Steffen Klassert
2011-01-31 16:31 ` Dave Hansen
2011-02-01 10:24   ` Steffen Klassert
2011-02-01 11:03     ` Steffen Klassert
2011-02-01 14:55       ` Dave Hansen [this message]
2011-02-01 15:20         ` Eric Paris
2011-02-02  7:55           ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296572145.27022.2837.camel@nimitz \ \ \ \ \ \ \
    --subject='Re: [PATCH] flex_array: Change behaviour on zero size allocations' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).