LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting
Date: Thu, 03 Feb 2011 11:01:23 -0800	[thread overview]
Message-ID: <1296759683.3336.306.camel@work-vm> (raw)
In-Reply-To: <20110203084309.GA20679@pengutronix.de>

On Thu, 2011-02-03 at 09:43 +0100, Wolfram Sang wrote:
> On Wed, Feb 02, 2011 at 06:14:41PM -0800, John Stultz wrote:
> > Some RTC drivers enable functionality directly via their ioctl method
> > instead of using the generic ioctl handling code. With the recent
> > virtualization of the RTC layer, its now important that the generic
> > layer always be used.
> > 
> > This patch moved the rtc driver ioctl method call to after the generic
> > ioctl processing is done. This allows hardware specific features or
> > ioctls to still function, while relying on the generic code for handling
> > everything else.
> 
> I guess the documentation should be updated, too. Currently it says:
> 
> Note that many of these ioctls need not actually be implemented by your
> driver.  The common rtc-dev interface handles many of these nicely if your
> driver returns ENOIOCTLCMD.  Some common examples:
> ...
> 
> That situation has changed after your patch.

Thanks for pointing that out. Although the code and comments were not
consistent even before my rework:
ie:
	 * Drivers *SHOULD NOT* provide ioctl implementations
	 * for these requests.  Instead, provide methods to
	 * support the following code, so that the RTC's main
	 * features are accessible without using ioctls.

But clearly that wasn't the case. :)

I've got a few additional cleanup patches I'll be posting to once I'm
feeling confident the posted fix resolves the issues Marcelo was having.

If anyone else is seeing problems with these fixes,  please do let me
know.

thanks
-john



  reply	other threads:[~2011-02-03 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03  2:14 [PATCH 0/4] RTC regression fixups John Stultz
2011-02-03  2:14 ` [PATCH 1/4] RTC: Prevents a division by zero in kernel code John Stultz
2011-02-03  2:14 ` [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting John Stultz
2011-02-03  8:43   ` Wolfram Sang
2011-02-03 19:01     ` John Stultz [this message]
2011-02-03  2:14 ` [PATCH 3/4] RTC: Convert rtc drivers to use the alarm_irq_enable method John Stultz
2011-02-03  2:14 ` [PATCH 4/4] RTC: Fix minor compile warning John Stultz
2011-02-03 17:30 ` [PATCH 0/4] RTC regression fixups Marcelo Roberto Jimenez
2011-02-03 19:16   ` John Stultz
2011-02-03 20:31     ` Marcelo Roberto Jimenez
2011-02-03 21:37       ` John Stultz
2011-02-03 22:27         ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296759683.3336.306.camel@work-vm \
    --to=john.stultz@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroberto@cpti.cetuc.puc-rio.br \
    --cc=tglx@linutronix.de \
    --cc=w.sang@pengutronix.de \
    --subject='Re: [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).