LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Cc: linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/4] RTC regression fixups
Date: Thu, 03 Feb 2011 11:16:16 -0800	[thread overview]
Message-ID: <1296760576.3336.324.camel@work-vm> (raw)
In-Reply-To: <AANLkTimO5FXDoA_egZ=7oR5FTV-Fx5qpjfPRZ7eT1q50@mail.gmail.com>

On Thu, 2011-02-03 at 15:30 -0200, Marcelo Roberto Jimenez wrote:
> Hi John,
> 
> On Thu, Feb 3, 2011 at 00:14, John Stultz <john.stultz@linaro.org> wrote:
> > ...
> > Marcelo: Mind giving this full patch set a go? It seems to resolve
> > the issues in my testing with the rtc-test driver.
> 
> I have tested the full set in ARM sa1100. Both the sa1100 RTC driver
> and the rtc-test driver are working fine.

Great to hear! Thanks for testing!

> The only difference in user space behaviour is, as I have mentioned on
> a previous message, that the rtc-test driver receives PIE events no
> matter what, while the previous behaviour was to receive them by
> echoing through the sys interface. But we must think whether this is
> something worth keeping or not.

Yes. With the generic code emulating PIE mode interrupts with an
hrtimer, instead of having it be driver triggered, its not something the
driver can control. So dropping the PIE control in the rtc-test driver
seems like the right approach.

Alessandro: Does this sound ok to you?

> You have actually saved me some work fixing the alarm/update broken
> behaviour on sa1100. Thank you very much. Most of the code in this rtc
> driver is going to /dev/null, I'll send a patch later.

Great. I'll add it to the follow on cleanup patches to remove dead code
that I'll be working on getting in my queue today.

thanks
-john


  reply	other threads:[~2011-02-03 19:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03  2:14 John Stultz
2011-02-03  2:14 ` [PATCH 1/4] RTC: Prevents a division by zero in kernel code John Stultz
2011-02-03  2:14 ` [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting John Stultz
2011-02-03  8:43   ` Wolfram Sang
2011-02-03 19:01     ` John Stultz
2011-02-03  2:14 ` [PATCH 3/4] RTC: Convert rtc drivers to use the alarm_irq_enable method John Stultz
2011-02-03  2:14 ` [PATCH 4/4] RTC: Fix minor compile warning John Stultz
2011-02-03 17:30 ` [PATCH 0/4] RTC regression fixups Marcelo Roberto Jimenez
2011-02-03 19:16   ` John Stultz [this message]
2011-02-03 20:31     ` Marcelo Roberto Jimenez
2011-02-03 21:37       ` John Stultz
2011-02-03 22:27         ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296760576.3336.324.camel@work-vm \
    --to=john.stultz@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroberto@cpti.cetuc.puc-rio.br \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 0/4] RTC regression fixups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).