LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Cc: linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/4] RTC regression fixups
Date: Thu, 03 Feb 2011 14:27:37 -0800	[thread overview]
Message-ID: <1296772057.3336.369.camel@work-vm> (raw)
In-Reply-To: <1296769047.3336.332.camel@work-vm>

On Thu, 2011-02-03 at 13:37 -0800, John Stultz wrote:
> On Thu, 2011-02-03 at 18:31 -0200, Marcelo Roberto Jimenez wrote:
> > 1 - Should the callback be removed or should it be kept and called in
> > the else part?
> 
> So, we probably should change the check to set_alarm or some other flag
> to check if the hardware supports irqs, then remove the driver
> read_alarm() function.

Ok. Just got a first pass on that done. Check out my dev/rtc-cleanups branch here:
http://git.linaro.org/gitweb?p=people/jstultz/linux.git;a=shortlog;h=refs/heads/dev/rtc-cleanups

So after cleaning up irq_set_state, irq_set_freq, update_irq_enable, and
read_alarm, we're looking at a nice reduction of code:

 54 files changed, 4 insertions(+), 2127 deletions(-)

Now, my one hesitation is for read_alarm. I'm not totally sure we won't
want to access that functionality from the generic layer at some point.
And I would hate to kill it and then realize we need it afterwards.

But it does nicely clean things up, so maybe we can decide on this by
the time 2.6.39 opens up.

Alessandro: Any thoughts?

thanks
-john



      reply	other threads:[~2011-02-03 22:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03  2:14 John Stultz
2011-02-03  2:14 ` [PATCH 1/4] RTC: Prevents a division by zero in kernel code John Stultz
2011-02-03  2:14 ` [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting John Stultz
2011-02-03  8:43   ` Wolfram Sang
2011-02-03 19:01     ` John Stultz
2011-02-03  2:14 ` [PATCH 3/4] RTC: Convert rtc drivers to use the alarm_irq_enable method John Stultz
2011-02-03  2:14 ` [PATCH 4/4] RTC: Fix minor compile warning John Stultz
2011-02-03 17:30 ` [PATCH 0/4] RTC regression fixups Marcelo Roberto Jimenez
2011-02-03 19:16   ` John Stultz
2011-02-03 20:31     ` Marcelo Roberto Jimenez
2011-02-03 21:37       ` John Stultz
2011-02-03 22:27         ` john stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296772057.3336.369.camel@work-vm \
    --to=johnstul@us.ibm.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroberto@cpti.cetuc.puc-rio.br \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 0/4] RTC regression fixups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).