From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149Ab1BFXPq (ORCPT ); Sun, 6 Feb 2011 18:15:46 -0500 Received: from gate.crashing.org ([63.228.1.57]:41610 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754100Ab1BFXPo (ORCPT ); Sun, 6 Feb 2011 18:15:44 -0500 Subject: Re: [PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions From: Benjamin Herrenschmidt To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org In-Reply-To: <1296136583-13815-3-git-send-email-akinobu.mita@gmail.com> References: <1296136583-13815-1-git-send-email-akinobu.mita@gmail.com> <1296136583-13815-3-git-send-email-akinobu.mita@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 Feb 2011 10:14:46 +1100 Message-ID: <1297034086.14982.8.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-01-27 at 22:56 +0900, Akinobu Mita wrote: > (This patch is intended to be folded into the patch in -mm: > powerpc-introduce-little-endian-bitops.patch) > > The little-endian bitops on powerpc are written as preprocessor > macros with the cast to "unsigned long *". > This means that even non-pointers will be accepted without an error, and > that is a Very Bad Thing. > > This converts the little-endian bitops macros to static inline functions > with proper prototypes. No objection to the powerpc variant of the patches. What is the status with the wholes series tho ? Does it looks like its going to be accepted ? Do you expect my Ack and will merge the whole thing at once ? Does it break bisection unless it's merged as one single giant patch ? Cheers, Ben.