LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata
@ 2011-02-14  2:49 Axel Lin
  2011-02-18  9:05 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-02-14  2:49 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ben Dooks, Kukjin Kim, Russell King, linux-arm-kernel

s3c24xx_ts_set_platdata is annotated __init and not used by any module,
thus don't export it.
This patch fixes below warning:

WARNING: arch/arm/plat-samsung/built-in.o(__ksymtab+0x90): Section mismatch in reference from the variable __ksymtab_s3c24xx_ts_set_platdata to the function .init.text:s3c24xx_ts_set_platdata()
The symbol s3c24xx_ts_set_platdata is exported and annotated __init
Fix this by removing the __init annotation of s3c24xx_ts_set_platdata or drop the export.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 arch/arm/plat-samsung/dev-ts.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-samsung/dev-ts.c b/arch/arm/plat-samsung/dev-ts.c
index 236ef84..3e4bd81 100644
--- a/arch/arm/plat-samsung/dev-ts.c
+++ b/arch/arm/plat-samsung/dev-ts.c
@@ -58,4 +58,3 @@ void __init s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *pd)
 
 	s3c_device_ts.dev.platform_data = npd;
 }
-EXPORT_SYMBOL(s3c24xx_ts_set_platdata);
-- 
1.7.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata
  2011-02-14  2:49 [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata Axel Lin
@ 2011-02-18  9:05 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2011-02-18  9:05 UTC (permalink / raw)
  To: 'Axel Lin', linux-kernel
  Cc: 'Ben Dooks', 'Russell King', linux-arm-kernel

Axel Lin wrote:
> 
> s3c24xx_ts_set_platdata is annotated __init and not used by any module,
> thus don't export it.
> This patch fixes below warning:
> 
> WARNING: arch/arm/plat-samsung/built-in.o(__ksymtab+0x90): Section
mismatch
> in reference from the variable __ksymtab_s3c24xx_ts_set_platdata to the
> function .init.text:s3c24xx_ts_set_platdata()
> The symbol s3c24xx_ts_set_platdata is exported and annotated __init
> Fix this by removing the __init annotation of s3c24xx_ts_set_platdata or
drop
> the export.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  arch/arm/plat-samsung/dev-ts.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/dev-ts.c
b/arch/arm/plat-samsung/dev-ts.c
> index 236ef84..3e4bd81 100644
> --- a/arch/arm/plat-samsung/dev-ts.c
> +++ b/arch/arm/plat-samsung/dev-ts.c
> @@ -58,4 +58,3 @@ void __init s3c24xx_ts_set_platdata(struct
> s3c2410_ts_mach_info *pd)
> 
>  	s3c_device_ts.dev.platform_data = npd;
>  }
> -EXPORT_SYMBOL(s3c24xx_ts_set_platdata);
> --
> 1.7.2
> 
Ok, applied.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-18  9:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-14  2:49 [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata Axel Lin
2011-02-18  9:05 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).