LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver
@ 2011-02-15 14:33 Benjamin Tissoires
  2011-02-15 23:04 ` Jiri Kosina
  0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Tissoires @ 2011-02-15 14:33 UTC (permalink / raw)
  To: Dmitry Torokhov, Henrik Rydberg, Benjamin Tissoires, Jiri Kosina,
	Stephane Chatty, linux-input, linux-kernel

Without this patch, the device is handled by hidinput and does
not have the right behavior.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
---
Hi guys,

In the previous patch including the support to IRTOUCH devices, I forgot to add it to hid_have_special_driver. Sorry.

Cheers,
Benjamin

 drivers/hid/hid-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index d678cf3..a5f6439 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1345,6 +1345,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HANVON, USB_DEVICE_ID_HANVON_MULTITOUCH) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_IRTOUCHSYSTEMS, USB_DEVICE_ID_IRTOUCH_INFRARED_USB) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON, USB_DEVICE_ID_KS_SLIMBLADE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
-- 
1.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver
  2011-02-15 14:33 [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver Benjamin Tissoires
@ 2011-02-15 23:04 ` Jiri Kosina
  2011-02-16  9:54   ` Benjamin Tissoires
  0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2011-02-15 23:04 UTC (permalink / raw)
  To: Benjamin Tissoires
  Cc: Dmitry Torokhov, Henrik Rydberg, Stephane Chatty, linux-input,
	linux-kernel

On Tue, 15 Feb 2011, Benjamin Tissoires wrote:

> Without this patch, the device is handled by hidinput and does
> not have the right behavior.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> ---
> Hi guys,
> 
> In the previous patch including the support to IRTOUCH devices, I forgot 
> to add it to hid_have_special_driver. Sorry.

Hmm, this happens quite often to people submitting patches, but I normally 
catch it. This time my eyes have failed.

Thanks for the fix, applied.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver
  2011-02-15 23:04 ` Jiri Kosina
@ 2011-02-16  9:54   ` Benjamin Tissoires
  2011-02-16 17:38     ` Jiri Kosina
  0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Tissoires @ 2011-02-16  9:54 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Dmitry Torokhov, Henrik Rydberg, Stephane Chatty, linux-input,
	linux-kernel

Hi Jiri,

Thanks for applying those two patches.
BTW I'm a little worried: apparently you applied this patch in the
branch upstream-fixes but you didn't applied "HID: hid-multitouch:
introduce IrTouch Infrared USB..." and it's parents in this branch....
I'm afraid this will broke compilation of the upstream branch
(USB_VENDOR_ID_IRTOUCHSYSTEMS and USB_DEVICE_ID_IRTOUCH_INFRARED_USB
are not defined).

Thanks,
Benjamin

On Wed, Feb 16, 2011 at 00:04, Jiri Kosina <jkosina@suse.cz> wrote:
> On Tue, 15 Feb 2011, Benjamin Tissoires wrote:
>
>> Without this patch, the device is handled by hidinput and does
>> not have the right behavior.
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
>> ---
>> Hi guys,
>>
>> In the previous patch including the support to IRTOUCH devices, I forgot
>> to add it to hid_have_special_driver. Sorry.
>
> Hmm, this happens quite often to people submitting patches, but I normally
> catch it. This time my eyes have failed.
>
> Thanks for the fix, applied.
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver
  2011-02-16  9:54   ` Benjamin Tissoires
@ 2011-02-16 17:38     ` Jiri Kosina
  2011-02-16 17:54       ` Benjamin Tissoires
  0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2011-02-16 17:38 UTC (permalink / raw)
  To: Benjamin Tissoires
  Cc: Dmitry Torokhov, Henrik Rydberg, Stephane Chatty, linux-input,
	linux-kernel

On Wed, 16 Feb 2011, Benjamin Tissoires wrote:

> Thanks for applying those two patches.
> BTW I'm a little worried: apparently you applied this patch in the
> branch upstream-fixes but you didn't applied "HID: hid-multitouch:
> introduce IrTouch Infrared USB..." and it's parents in this branch....
> I'm afraid this will broke compilation of the upstream branch
> (USB_VENDOR_ID_IRTOUCHSYSTEMS and USB_DEVICE_ID_IRTOUCH_INFRARED_USB
> are not defined).

Hi,

yes, I pushed the patch to wrong remote branch yesterday, but apparently 
sync to git.kernel.org in which I fixed it hasn't made it yet for some 
reason.

Sorry for the noise,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver
  2011-02-16 17:38     ` Jiri Kosina
@ 2011-02-16 17:54       ` Benjamin Tissoires
  0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2011-02-16 17:54 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Dmitry Torokhov, Henrik Rydberg, Stephane Chatty, linux-input,
	linux-kernel

On Wed, Feb 16, 2011 at 18:38, Jiri Kosina <jkosina@suse.cz> wrote:
> On Wed, 16 Feb 2011, Benjamin Tissoires wrote:
>
>> Thanks for applying those two patches.
>> BTW I'm a little worried: apparently you applied this patch in the
>> branch upstream-fixes but you didn't applied "HID: hid-multitouch:
>> introduce IrTouch Infrared USB..." and it's parents in this branch....
>> I'm afraid this will broke compilation of the upstream branch
>> (USB_VENDOR_ID_IRTOUCHSYSTEMS and USB_DEVICE_ID_IRTOUCH_INFRARED_USB
>> are not defined).
>
> Hi,
>
> yes, I pushed the patch to wrong remote branch yesterday, but apparently
> sync to git.kernel.org in which I fixed it hasn't made it yet for some
> reason.
>
> Sorry for the noise,

No problem, and after all it was my fault at the beginning ;)

Thanks for taking care of this.

Cheers,
Benjamin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-02-16 17:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-15 14:33 [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver Benjamin Tissoires
2011-02-15 23:04 ` Jiri Kosina
2011-02-16  9:54   ` Benjamin Tissoires
2011-02-16 17:38     ` Jiri Kosina
2011-02-16 17:54       ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).