LKML Archive on
help / color / mirror / Atom feed
From: Don Zickus <>
Cc: LKML <>, Don Zickus <>
Subject: [PATCH] x86: use int instead of long to set reset vector back to 0
Date: Wed, 23 Feb 2011 17:12:31 -0500	[thread overview]
Message-ID: <> (raw)

A customer of ours, complained that when setting the reset vector
back to 0, it trashed other data and hung their box.  They noticed
when only 4 bytes were set to 0 instead of 8, everything worked

I don't know where to find this in the spec to know if this is
correct, but looking at historical info of the code, x86_64 used
to use 'int' here whereas i386 used to use 'long'.  When they got
merged it seemed like 'long' was used.  So the change seems to
make sense from that point of view.

I am hoping someone smarter than me can verify this.

Signed-off-by: Don Zickus <>
Reposting this in case it was lost in the noise

 arch/x86/include/asm/smpboot_hooks.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/smpboot_hooks.h b/arch/x86/include/asm/smpboot_hooks.h
index 6c22bf3..42d0366 100644
--- a/arch/x86/include/asm/smpboot_hooks.h
+++ b/arch/x86/include/asm/smpboot_hooks.h
@@ -34,7 +34,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
 	CMOS_WRITE(0, 0xf);
-	*((volatile long *)phys_to_virt(apic->trampoline_phys_low)) = 0;
+	*((volatile int *)phys_to_virt(apic->trampoline_phys_low)) = 0;
 static inline void __init smpboot_setup_io_apic(void)

             reply	other threads:[~2011-02-23 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 22:12 Don Zickus [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-02-08  4:25 Don Zickus
2011-02-28 15:15 ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] x86: use int instead of long to set reset vector back to 0' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).