LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org> To: Russell King <linux@arm.linux.org.uk> Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Saravana Kannan <skannan@codeaurora.org>, Nicolas Pitre <nicolas.pitre@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, Mattias Wallin <Mattias.Wallin@stericsson.com>, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCHv5 0/3] Constant udelay() for SMP and non-SMP systems Date: Tue, 5 Apr 2011 16:56:37 -0700 [thread overview] Message-ID: <1302047800-26720-1-git-send-email-sboyd@codeaurora.org> (raw) Note: I will submit this to the patch tracker in 48 hours. Tested by are appreciated. These patches fix the udelay() issue pointed out on arm-lkml[1][2]. A quick recap: some SMP machines can scale their CPU frequencies independent of one another. loops_per_jiffy is calibrated globally and used in __const_udelay(). If one CPU is running faster than what the loops_per_jiffy is calculated (or scaled) for, udelay() will be incorrect and not wait long enough (or too long). A similar problem occurs if the cpu frequency is scaled during a udelay() call. We could fix this issue a couple ways, wholesale replacement of __udelay() and __const_udelay() (see [2] for that approach), or replacement of __delay() (this series). Option 1 can fail if anybody uses udelay() before memory is mapped and also duplicates most of the code in asm/delay.h. It also needs to hardcode the timer tick frequency, which can sometimes be inaccurate. The benefit is that loops_per_jiffy stays the same and thus BogoMIPS is unchanged. Option 2 cannot fail since the __delay() loop is repointed after memory is mapped in, but it suffers from a low BogoMIPS when timers are clocked slowly. It also more accurately calculates the timer tick frequency through the use of calibrate_delay_direct(). -- Reference -- [1] http://article.gmane.org/gmane.linux.kernel/977567 [2] http://article.gmane.org/gmane.linux.ports.arm.kernel/78496 Changes since v4: * Rebased against changes to udelay.S Changes since v3: * Inlined set_delay_fn() Changes since v2: * Additional patch using the timer based delay Changes since v1: * likely() in delay.c * comment fixup for read_current_timer_delay_loop() * cosmetic improvements to commit text Stephen Boyd (3): ARM: Translate delay.S into (mostly) C ARM: Allow machines to override __delay() ARM: Implement a timer based __delay() loop arch/arm/include/asm/delay.h | 11 +++++- arch/arm/kernel/armksyms.c | 4 -- arch/arm/lib/delay.S | 69 --------------------------------- arch/arm/lib/delay.c | 87 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 97 insertions(+), 74 deletions(-) delete mode 100644 arch/arm/lib/delay.S create mode 100644 arch/arm/lib/delay.c -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next reply other threads:[~2011-04-05 23:56 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-05 23:56 Stephen Boyd [this message] 2011-04-05 23:56 ` [PATCHv5 1/3] ARM: Translate delay.S into (mostly) C Stephen Boyd 2011-04-06 8:49 ` Mattias Wallin 2011-04-06 17:34 ` Stephen Boyd 2011-04-07 1:27 ` Saravana Kannan 2011-04-07 7:27 ` Mattias Wallin 2011-04-07 7:29 ` Mattias Wallin 2011-04-05 23:56 ` [PATCHv5 2/3] ARM: Allow machines to override __delay() Stephen Boyd 2011-04-07 7:30 ` Mattias Wallin 2011-04-05 23:56 ` [PATCHv5 3/3] ARM: Implement a timer based __delay() loop Stephen Boyd 2011-04-07 7:30 ` Mattias Wallin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1302047800-26720-1-git-send-email-sboyd@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=Mattias.Wallin@stericsson.com \ --cc=akpm@linux-foundation.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=nicolas.pitre@linaro.org \ --cc=skannan@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).