LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/3] Char: mxser_new, do not null driver_data
@ 2007-01-23 14:42 Jiri Slaby
  2007-01-23 14:42 ` [PATCH 2/3] Char: mxser_new, lock count and flags Jiri Slaby
  2007-01-23 14:42 ` [PATCH 3/3] Char: mxser_new, fix sparse warning Jiri Slaby
  0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby @ 2007-01-23 14:42 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, osv

mxser_new, do not null driver_data

driver_data are initialzed to NULL from tty layer, no need to do it in the
driver. In this case it cases oops, since driver_data may be NULL for a
short while for another closing process.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: <osv@javad.com>

---
commit f49b6914c3113f930a31ff7b8f811744f2d8f339
tree d4f8355eb12a89f779dc4b85e7a908b9e80e88d3
parent 2826e3a35f34046890c84a77bc2784a184f9bf6a
author Jiri Slaby <jirislaby@gmail.com> Sat, 20 Jan 2007 17:00:12 +0059
committer Jiri Slaby <jirislaby@gmail.com> Sat, 20 Jan 2007 17:00:12 +0059

 drivers/char/mxser_new.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 4c80549..1c8e00c 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -927,9 +927,6 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
 	struct mxser_port *info;
 	int retval, line;
 
-	/* initialize driver_data in case something fails */
-	tty->driver_data = NULL;
-
 	line = tty->index;
 	if (line == MXSER_PORTS)
 		return 0;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-01-23 14:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-23 14:42 [PATCH 1/3] Char: mxser_new, do not null driver_data Jiri Slaby
2007-01-23 14:42 ` [PATCH 2/3] Char: mxser_new, lock count and flags Jiri Slaby
2007-01-23 14:42 ` [PATCH 3/3] Char: mxser_new, fix sparse warning Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).