LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dell-smo8800: Add more acpi ids and change description of driver
@ 2014-09-29 12:45 Pali Rohár
  2014-09-29 20:56 ` Darren Hart
  0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2014-09-29 12:45 UTC (permalink / raw)
  To: Darren Hart; +Cc: platform-driver-x86, linux-kernel, Pali Rohár

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/platform/x86/Kconfig        |    4 ++--
 drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3bbcbf1..ba9ee4f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -128,10 +128,10 @@ config DELL_WMI_AIO
 	  be called dell-wmi-aio.
 
 config DELL_SMO8800
-	tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+	tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
 	depends on ACPI
 	---help---
-	  Say Y here if you want to support SMO8800/SMO8810 freefall device
+	  Say Y here if you want to support SMO88XX freefall device
 	  on Dell Latitude laptops.
 
 	  To compile this driver as a module, choose M here: the module will
diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c
index a653716..0aec4fd 100644
--- a/drivers/platform/x86/dell-smo8800.c
+++ b/drivers/platform/x86/dell-smo8800.c
@@ -1,5 +1,5 @@
 /*
- *  dell-smo8800.c - Dell Latitude ACPI SMO8800/SMO8810 freefall sensor driver
+ *  dell-smo8800.c - Dell Latitude ACPI SMO88XX freefall sensor driver
  *
  *  Copyright (C) 2012 Sonal Santan <sonal.santan@gmail.com>
  *  Copyright (C) 2014 Pali Rohár <pali.rohar@gmail.com>
@@ -209,7 +209,13 @@ static int smo8800_remove(struct acpi_device *device)
 
 static const struct acpi_device_id smo8800_ids[] = {
 	{ "SMO8800", 0 },
+	{ "SMO8801", 0 },
 	{ "SMO8810", 0 },
+	{ "SMO8811", 0 },
+	{ "SMO8820", 0 },
+	{ "SMO8821", 0 },
+	{ "SMO8830", 0 },
+	{ "SMO8831", 0 },
 	{ "", 0 },
 };
 
@@ -228,6 +234,6 @@ static struct acpi_driver smo8800_driver = {
 
 module_acpi_driver(smo8800_driver);
 
-MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO8800/SMO8810)");
+MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO88XX)");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Sonal Santan, Pali Rohár");
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver
  2014-09-29 12:45 [PATCH] dell-smo8800: Add more acpi ids and change description of driver Pali Rohár
@ 2014-09-29 20:56 ` Darren Hart
  2014-11-23  2:38   ` Pali Rohár
  0 siblings, 1 reply; 6+ messages in thread
From: Darren Hart @ 2014-09-29 20:56 UTC (permalink / raw)
  To: Pali Rohár; +Cc: platform-driver-x86, linux-kernel, linux-acpi

On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:

Please see Documentation/SubmittingPatches, 15) The canonical patch format, and
provide a complete message body.

Have you validated each of the 6 ACPI IDs added to the driver?


> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
>  drivers/platform/x86/Kconfig        |    4 ++--
>  drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 3bbcbf1..ba9ee4f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -128,10 +128,10 @@ config DELL_WMI_AIO
>  	  be called dell-wmi-aio.
>  
>  config DELL_SMO8800
> -	tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
> +	tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
>  	depends on ACPI
>  	---help---
> -	  Say Y here if you want to support SMO8800/SMO8810 freefall device
> +	  Say Y here if you want to support SMO88XX freefall device

"devices" now that multiple are supported.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver
  2014-09-29 20:56 ` Darren Hart
@ 2014-11-23  2:38   ` Pali Rohár
  2014-12-03 13:43     ` Darren Hart
  0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2014-11-23  2:38 UTC (permalink / raw)
  To: Darren Hart; +Cc: platform-driver-x86, linux-kernel, linux-acpi

[-- Attachment #1: Type: Text/Plain, Size: 1713 bytes --]

Oops, I lost this mail somewhere...

I copied these ids from windows driver inf file. I did not tested 
them because I do not have machine which reports these ids. It 
looks like all SMOXX devices have same acpi structure (one IRQ). 
So adding ids could not break anything (if acpi device will not 
have for some reason IRQ specified, device probe function will 
fail).

On Monday 29 September 2014 22:56:04 Darren Hart wrote:
> On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:
> 
> Please see Documentation/SubmittingPatches, 15) The canonical
> patch format, and provide a complete message body.
> 
> Have you validated each of the 6 ACPI IDs added to the driver?
> 
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > 
> >  drivers/platform/x86/Kconfig        |    4 ++--
> >  drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
> >  2 files changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f
> > 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> > 
> >  	  be called dell-wmi-aio.
> >  
> >  config DELL_SMO8800
> > 
> > -	tristate "Dell Latitude freefall driver (ACPI
> > SMO8800/SMO8810)" +	tristate "Dell Latitude freefall driver
> > (ACPI SMO88XX)"
> > 
> >  	depends on ACPI
> >  	---help---
> > 
> > -	  Say Y here if you want to support SMO8800/SMO8810
> > freefall device +	  Say Y here if you want to support
> > SMO88XX freefall device
> 
> "devices" now that multiple are supported.
> 
> Thanks,

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver
  2014-11-23  2:38   ` Pali Rohár
@ 2014-12-03 13:43     ` Darren Hart
  2014-12-05 12:05       ` [PATCH v2] dell-smo8800: Add more ACPI " Pali Rohár
  0 siblings, 1 reply; 6+ messages in thread
From: Darren Hart @ 2014-12-03 13:43 UTC (permalink / raw)
  To: Pali Rohár; +Cc: platform-driver-x86, linux-kernel, linux-acpi

On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote:
> Oops, I lost this mail somewhere...
> 
> I copied these ids from windows driver inf file. I did not tested 
> them because I do not have machine which reports these ids. It 
> looks like all SMOXX devices have same acpi structure (one IRQ). 
> So adding ids could not break anything (if acpi device will not 
> have for some reason IRQ specified, device probe function will 
> fail).

Please resend with a complete message body and the typo fix below.

> 
> On Monday 29 September 2014 22:56:04 Darren Hart wrote:
> > On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:
> > 
> > Please see Documentation/SubmittingPatches, 15) The canonical
> > patch format, and provide a complete message body.
> > 
> > Have you validated each of the 6 ACPI IDs added to the driver?
> > 
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > ---
> > > 
> > >  drivers/platform/x86/Kconfig        |    4 ++--
> > >  drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
> > >  2 files changed, 10 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/Kconfig
> > > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f
> > > 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> > > 
> > >  	  be called dell-wmi-aio.
> > >  
> > >  config DELL_SMO8800
> > > 
> > > -	tristate "Dell Latitude freefall driver (ACPI
> > > SMO8800/SMO8810)" +	tristate "Dell Latitude freefall driver
> > > (ACPI SMO88XX)"
> > > 
> > >  	depends on ACPI
> > >  	---help---
> > > 
> > > -	  Say Y here if you want to support SMO8800/SMO8810
> > > freefall device +	  Say Y here if you want to support
> > > SMO88XX freefall device
> > 
> > "devices" now that multiple are supported.
> > 
> > Thanks,
> 
> -- 
> Pali Rohár
> pali.rohar@gmail.com



-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] dell-smo8800: Add more ACPI ids and change description of driver
  2014-12-05 12:05       ` [PATCH v2] dell-smo8800: Add more ACPI " Pali Rohár
@ 2014-12-03 18:07         ` Darren Hart
  0 siblings, 0 replies; 6+ messages in thread
From: Darren Hart @ 2014-12-03 18:07 UTC (permalink / raw)
  To: Pali Rohár; +Cc: platform-driver-x86, linux-kernel, linux-acpi

On Fri, Dec 05, 2014 at 01:05:46PM +0100, Pali Rohár wrote:
> This patch adds other ACPI ids from Windows inf driver which should be handled
> by dell-smo8800 driver. ACPI devices have same structure -- one IRQ number.
> 
> This patch also updates description of module.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>

Queued to testing, thanks Pali.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] dell-smo8800: Add more ACPI ids and change description of driver
  2014-12-03 13:43     ` Darren Hart
@ 2014-12-05 12:05       ` Pali Rohár
  2014-12-03 18:07         ` Darren Hart
  0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2014-12-05 12:05 UTC (permalink / raw)
  To: Darren Hart
  Cc: platform-driver-x86, linux-kernel, linux-acpi, Pali Rohár

This patch adds other ACPI ids from Windows inf driver which should be handled
by dell-smo8800 driver. ACPI devices have same structure -- one IRQ number.

This patch also updates description of module.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/platform/x86/Kconfig        |    4 ++--
 drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3bbcbf1..4614f35 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -128,10 +128,10 @@ config DELL_WMI_AIO
 	  be called dell-wmi-aio.
 
 config DELL_SMO8800
-	tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+	tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
 	depends on ACPI
 	---help---
-	  Say Y here if you want to support SMO8800/SMO8810 freefall device
+	  Say Y here if you want to support SMO88XX freefall devices
 	  on Dell Latitude laptops.
 
 	  To compile this driver as a module, choose M here: the module will
diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c
index a653716..0aec4fd 100644
--- a/drivers/platform/x86/dell-smo8800.c
+++ b/drivers/platform/x86/dell-smo8800.c
@@ -1,5 +1,5 @@
 /*
- *  dell-smo8800.c - Dell Latitude ACPI SMO8800/SMO8810 freefall sensor driver
+ *  dell-smo8800.c - Dell Latitude ACPI SMO88XX freefall sensor driver
  *
  *  Copyright (C) 2012 Sonal Santan <sonal.santan@gmail.com>
  *  Copyright (C) 2014 Pali Rohár <pali.rohar@gmail.com>
@@ -209,7 +209,13 @@ static int smo8800_remove(struct acpi_device *device)
 
 static const struct acpi_device_id smo8800_ids[] = {
 	{ "SMO8800", 0 },
+	{ "SMO8801", 0 },
 	{ "SMO8810", 0 },
+	{ "SMO8811", 0 },
+	{ "SMO8820", 0 },
+	{ "SMO8821", 0 },
+	{ "SMO8830", 0 },
+	{ "SMO8831", 0 },
 	{ "", 0 },
 };
 
@@ -228,6 +234,6 @@ static struct acpi_driver smo8800_driver = {
 
 module_acpi_driver(smo8800_driver);
 
-MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO8800/SMO8810)");
+MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO88XX)");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Sonal Santan, Pali Rohár");
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-12-06  4:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-29 12:45 [PATCH] dell-smo8800: Add more acpi ids and change description of driver Pali Rohár
2014-09-29 20:56 ` Darren Hart
2014-11-23  2:38   ` Pali Rohár
2014-12-03 13:43     ` Darren Hart
2014-12-05 12:05       ` [PATCH v2] dell-smo8800: Add more ACPI " Pali Rohár
2014-12-03 18:07         ` Darren Hart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).