LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: dahi@linux.vnet.ibm.com, cornelia.huck@de.ibm.com,
	rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org
Subject: [PATCH v3 1/6] virtio: add API to detect legacy devices
Date: Mon, 8 Dec 2014 15:05:51 +0200	[thread overview]
Message-ID: <1418042769-25539-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1418042769-25539-1-git-send-email-mst@redhat.com>

transports need to be able to detect legacy-only
devices (ATM balloon only) to use legacy path
to drive them.

Add a core API to do just that.
The implementation just blacklists balloon:
not too pretty, but let's not over-engineer.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 include/linux/virtio.h  | 2 ++
 drivers/virtio/virtio.c | 7 +++++++
 2 files changed, 9 insertions(+)

diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 2bbf626..d666bcb 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -108,6 +108,8 @@ struct virtio_device {
 	void *priv;
 };
 
+bool virtio_device_is_legacy_only(struct virtio_device_id id);
+
 static inline struct virtio_device *dev_to_virtio(struct device *_dev)
 {
 	return container_of(_dev, struct virtio_device, dev);
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index fa6b75d..224f854 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -3,6 +3,7 @@
 #include <linux/virtio_config.h>
 #include <linux/module.h>
 #include <linux/idr.h>
+#include <uapi/linux/virtio_ids.h>
 
 /* Unique numbering for virtio devices. */
 static DEFINE_IDA(virtio_index_ida);
@@ -267,6 +268,12 @@ static struct bus_type virtio_bus = {
 	.remove = virtio_dev_remove,
 };
 
+bool virtio_device_is_legacy_only(struct virtio_device_id id)
+{
+	return id.device == VIRTIO_ID_BALLOON;
+}
+EXPORT_SYMBOL_GPL(virtio_device_is_legacy_only);
+
 int register_virtio_driver(struct virtio_driver *driver)
 {
 	/* Catch this early. */
-- 
MST


  reply	other threads:[~2014-12-08 13:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 13:05 [PATCH v3 0/6] virtio 1.0 enhancements Michael S. Tsirkin
2014-12-08 13:05 ` Michael S. Tsirkin [this message]
2014-12-08 13:05 ` [PATCH v3 2/6] virtio_ccw: legacy: don't negotiate rev 1/features Michael S. Tsirkin
2014-12-09 10:35   ` Cornelia Huck
2014-12-08 13:05 ` [PATCH v3 3/6] virtio: allow finalize_features to fail Michael S. Tsirkin
2014-12-09 10:46   ` Cornelia Huck
2014-12-09 12:07     ` Michael S. Tsirkin
2014-12-09 12:56       ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 4/6] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 Michael S. Tsirkin
2014-12-09 11:01   ` Cornelia Huck
2014-12-09 12:21     ` Michael S. Tsirkin
2014-12-09 17:23       ` Cornelia Huck
2014-12-09 18:55         ` Michael S. Tsirkin
2014-12-09 19:40         ` Michael S. Tsirkin
2014-12-10  8:41           ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 5/6] virtio_balloon: drop legacy_only driver flag Michael S. Tsirkin
2014-12-09 11:24   ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 6/6] virtio: " Michael S. Tsirkin
2014-12-09 11:24   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418042769-25539-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    --subject='Re: [PATCH v3 1/6] virtio: add API to detect legacy devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).