LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: dahi@linux.vnet.ibm.com, cornelia.huck@de.ibm.com,
	rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org
Subject: [PATCH v3 6/6] virtio: drop legacy_only driver flag
Date: Mon, 8 Dec 2014 15:06:10 +0200	[thread overview]
Message-ID: <1418042769-25539-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1418042769-25539-1-git-send-email-mst@redhat.com>

legacy_only flag is now unused, drop it from core.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/virtio.h  | 2 --
 drivers/virtio/virtio.c | 4 ----
 2 files changed, 6 deletions(-)

diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index d666bcb..d09e093 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -134,7 +134,6 @@ int virtio_device_restore(struct virtio_device *dev);
  * @feature_table_size: number of entries in the feature table array.
  * @feature_table_legacy: same as feature_table but when working in legacy mode.
  * @feature_table_size_legacy: number of entries in feature table legacy array.
- * @legacy_only: driver does not support virtio 1.0.
  * @probe: the function to call when a device is found.  Returns 0 or -errno.
  * @remove: the function to call when a device is removed.
  * @config_changed: optional function to call when the device configuration
@@ -147,7 +146,6 @@ struct virtio_driver {
 	unsigned int feature_table_size;
 	const unsigned int *feature_table_legacy;
 	unsigned int feature_table_size_legacy;
-	bool legacy_only;
 	int (*probe)(struct virtio_device *dev);
 	void (*scan)(struct virtio_device *dev);
 	void (*remove)(struct virtio_device *dev);
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index e1673a5..f226658 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -198,10 +198,6 @@ static int virtio_dev_probe(struct device *_d)
 		driver_features_legacy = driver_features;
 	}
 
-	/* Detect legacy-only drivers and disable VIRTIO_F_VERSION_1. */
-	if (drv->legacy_only)
-		device_features &= ~(1ULL << VIRTIO_F_VERSION_1);
-
 	if (device_features & (1ULL << VIRTIO_F_VERSION_1))
 		dev->features = driver_features & device_features;
 	else
-- 
MST


  parent reply	other threads:[~2014-12-08 13:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 13:05 [PATCH v3 0/6] virtio 1.0 enhancements Michael S. Tsirkin
2014-12-08 13:05 ` [PATCH v3 1/6] virtio: add API to detect legacy devices Michael S. Tsirkin
2014-12-08 13:05 ` [PATCH v3 2/6] virtio_ccw: legacy: don't negotiate rev 1/features Michael S. Tsirkin
2014-12-09 10:35   ` Cornelia Huck
2014-12-08 13:05 ` [PATCH v3 3/6] virtio: allow finalize_features to fail Michael S. Tsirkin
2014-12-09 10:46   ` Cornelia Huck
2014-12-09 12:07     ` Michael S. Tsirkin
2014-12-09 12:56       ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 4/6] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 Michael S. Tsirkin
2014-12-09 11:01   ` Cornelia Huck
2014-12-09 12:21     ` Michael S. Tsirkin
2014-12-09 17:23       ` Cornelia Huck
2014-12-09 18:55         ` Michael S. Tsirkin
2014-12-09 19:40         ` Michael S. Tsirkin
2014-12-10  8:41           ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 5/6] virtio_balloon: drop legacy_only driver flag Michael S. Tsirkin
2014-12-09 11:24   ` Cornelia Huck
2014-12-08 13:06 ` Michael S. Tsirkin [this message]
2014-12-09 11:24   ` [PATCH v3 6/6] virtio: " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418042769-25539-7-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    --subject='Re: [PATCH v3 6/6] virtio: drop legacy_only driver flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).