LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v2 04/10] virtio_pci: use priv for vq notification
Date: Mon, 8 Dec 2014 17:16:43 +0200	[thread overview]
Message-ID: <1418051779-27748-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1418051779-27748-1-git-send-email-mst@redhat.com>

slightly reduce the amount of pointer chasing this needs to do.
More importantly, this will easily generalize to virtio 1.0.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio_pci.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 6a7b8bf..7b82eb5 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -204,11 +204,9 @@ static void vp_reset(struct virtio_device *vdev)
 /* the notify function used when creating a virt queue */
 static bool vp_notify(struct virtqueue *vq)
 {
-	struct virtio_pci_device *vp_dev = to_vp_device(vq->vdev);
-
 	/* we write the queue's selector into the notification register to
 	 * signal the other end */
-	iowrite16(vq->index, vp_dev->ioaddr + VIRTIO_PCI_QUEUE_NOTIFY);
+	iowrite16(vq->index, (void __iomem *)vq->priv);
 	return true;
 }
 
@@ -437,6 +435,7 @@ static struct virtqueue *setup_vq(struct virtio_device *vdev, unsigned index,
 		goto out_activate_queue;
 	}
 
+	vq->priv = (void __force *)vp_dev->ioaddr + VIRTIO_PCI_QUEUE_NOTIFY;
 	info->vq = vq;
 
 	if (msix_vec != VIRTIO_MSI_NO_VECTOR) {
-- 
MST


  parent reply	other threads:[~2014-12-08 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 15:16 [PATCH v2 00/10] virtio_pci: split out legacy device support Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 01/10] virtio_pci: add isr field Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 02/10] virtio_pci: fix coding style for structs Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 03/10] virtio_pci: free up vq->priv Michael S. Tsirkin
2014-12-08 15:16 ` Michael S. Tsirkin [this message]
2014-12-08 15:16 ` [PATCH v2 05/10] virtio_pci: delete vqs indirectly Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 06/10] virtio_pci: setup " Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 07/10] virtio_pci: setup config vector indirectly Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 08/10] virtio_pci: split out legacy device support Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 09/10] virtio_pci: update file descriptions and copyright Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 10/10] virtio_pci: rename virtio_pci -> virtio_pci_common Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418051779-27748-5-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    --subject='Re: [PATCH v2 04/10] virtio_pci: use priv for vq notification' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).