LKML Archive on
help / color / mirror / Atom feed
From: Michael Ellerman <>
To: Pranith Kumar <>
Cc: Benjamin Herrenschmidt <>,
	Paul Mackerras <>,
	"Srivatsa S. Bhat" <>,
	"Rafael J. Wysocki" <>,
	"Gautham R. Shenoy" <>,
	Michael Neuling <>,
	"open list:LINUX FOR POWERPC..." <>,
	open list <>,
Subject: Re: [PATCH] powerpc/powernv: Select CONFIG_PRINTK to fix build failure
Date: Mon, 29 Dec 2014 20:01:47 +1100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, 2014-12-27 at 12:17 -0500, Pranith Kumar wrote:
> In an allnoconfig we get the following build failure:
An allnoconfig doesn't include CONFIG_PPC_POWERNV? But I think I know what you

> arch/powerpc/platforms/built-in.o: In function `.__machine_initcall_powernv_opal_init':
> opal.c:(.init.text+0x468): undefined reference to `.log_buf_addr_get'
> opal.c:(.init.text+0x474): undefined reference to `.log_buf_len_get'
> make: *** [vmlinux] Error 1
> This happens because powernv requires printk() support. Enable it in the config
> file.

Sort of. It just requires those two routines. Or is there a stronger

I think the better fix is for those two routines to be defined for
CONFIG_PRINTK=n, but return NULL and zero respectively.

And the opal code could skip registering the region when they return NULL/zero.

Care to do a couple of patches?


  reply	other threads:[~2014-12-29  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27 17:17 [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU Pranith Kumar
2014-12-27 17:17 ` [PATCH] powerpc/powernv: Select CONFIG_PRINTK to fix build failure Pranith Kumar
2014-12-29  9:01   ` Michael Ellerman [this message]
2014-12-30  5:46     ` Pranith Kumar
2014-12-29 10:03 ` [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU Martin Schwidefsky
2014-12-30  4:32   ` Pranith Kumar
2014-12-30 19:44     ` Scott Wood
2014-12-29 23:05 ` Scott Wood
2014-12-30  5:06   ` Pranith Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] powerpc/powernv: Select CONFIG_PRINTK to fix build failure' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).