LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c
@ 2014-12-29 9:12 jitendra kumar khasdev
2014-12-30 22:19 ` Ian Abbott
2015-01-10 1:00 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: jitendra kumar khasdev @ 2014-12-29 9:12 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, sudipm.mukherjee
Cc: devel, linux-kernel, jitendra kumar khasdev
This is a patch to the s626.c file that fixes up a space error
found by the checkpatch.pl tool
Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 14932c5..fc497dd 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
static void s626_mc_disable(struct comedi_device *dev,
unsigned int cmd, unsigned int reg)
{
- writel(cmd << 16 , dev->mmio + reg);
+ writel(cmd << 16, dev->mmio + reg);
mmiowb();
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c
2014-12-29 9:12 [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c jitendra kumar khasdev
@ 2014-12-30 22:19 ` Ian Abbott
2015-01-10 1:00 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2014-12-30 22:19 UTC (permalink / raw)
To: jitendra kumar khasdev, hsweeten, gregkh, sudipm.mukherjee
Cc: devel, linux-kernel
On 29/12/14 09:12, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up a space error
> found by the checkpatch.pl tool
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/s626.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 14932c5..fc497dd 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
> static void s626_mc_disable(struct comedi_device *dev,
> unsigned int cmd, unsigned int reg)
> {
> - writel(cmd << 16 , dev->mmio + reg);
> + writel(cmd << 16, dev->mmio + reg);
> mmiowb();
> }
Presumably this is PATCH 1/2?
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c
2014-12-29 9:12 [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c jitendra kumar khasdev
2014-12-30 22:19 ` Ian Abbott
@ 2015-01-10 1:00 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-01-10 1:00 UTC (permalink / raw)
To: jitendra kumar khasdev
Cc: abbotti, hsweeten, sudipm.mukherjee, devel, linux-kernel
On Mon, Dec 29, 2014 at 02:42:56PM +0530, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up a space error
> found by the checkpatch.pl tool
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> ---
> drivers/staging/comedi/drivers/s626.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 14932c5..fc497dd 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
> static void s626_mc_disable(struct comedi_device *dev,
> unsigned int cmd, unsigned int reg)
> {
> - writel(cmd << 16 , dev->mmio + reg);
> + writel(cmd << 16, dev->mmio + reg);
> mmiowb();
> }
>
> --
> 1.9.1
Someone already sent this patch in before you :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-10 1:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-29 9:12 [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c jitendra kumar khasdev
2014-12-30 22:19 ` Ian Abbott
2015-01-10 1:00 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).