LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com> To: Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Pawel Moll <pawel.moll@arm.com>, Pantelis Antoniou <pantelis.antoniou@konsulko.com>, Felipe Balbi <balbi@ti.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-omap@vger.kernel.org>, Suman Anna <s-anna@ti.com> Subject: [RFC PATCH 3/3] of/unittest: fix trailing semi-colons on conditional selftest Date: Wed, 7 Jan 2015 11:30:54 -0600 [thread overview] Message-ID: <1420651854-17768-4-git-send-email-s-anna@ti.com> (raw) In-Reply-To: <1420651854-17768-1-git-send-email-s-anna@ti.com> The of_platform_populate() and of_platform_depopulate() tests are not really being tested because of some additional trailing semi-colons after the conditional checks on couple of selftest macro usage. Remove them to properly run all the platform tests. Fixes: 851da976dc1d (of/unittest: Remove test devices after adding them) Signed-off-by: Suman Anna <s-anna@ti.com> --- drivers/of/unittest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 844838e11ef1..c67e50264e82 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -765,11 +765,11 @@ static void __init of_selftest_platform_populate(void) selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"), - "No testcase data in device tree\n")); + "No testcase data in device tree\n")) return; if (selftest(!(rc = device_register(&test_bus)), - "testbus registration failed; rc=%i\n", rc)); + "testbus registration failed; rc=%i\n", rc)) return; for_each_child_of_node(np, child) { -- 2.2.1
prev parent reply other threads:[~2015-01-07 17:31 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-07 17:30 [RFC PATCH 0/3] of_platform_depopulate crash fixes Suman Anna 2015-01-07 17:30 ` [RFC PATCH 1/3] of/device: manage resources similar to platform_device_add Suman Anna 2015-01-13 20:38 ` Rob Herring 2015-01-13 21:25 ` Suman Anna 2015-01-13 22:00 ` Rob Herring 2015-01-13 23:04 ` Suman Anna 2015-01-22 21:49 ` Suman Anna 2015-03-20 11:29 ` Grant Likely 2015-01-07 17:30 ` [RFC PATCH 2/3] core: platform: fix an invalid kfree during of_platform_depopulate Suman Anna 2015-01-13 22:27 ` Rob Herring 2015-01-13 22:53 ` Suman Anna 2015-01-07 17:30 ` Suman Anna [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1420651854-17768-4-git-send-email-s-anna@ti.com \ --to=s-anna@ti.com \ --cc=balbi@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=pantelis.antoniou@konsulko.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).