From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbbANNwD (ORCPT ); Wed, 14 Jan 2015 08:52:03 -0500 Received: from andre.telenet-ops.be ([195.130.132.53]:56409 "EHLO andre.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbbANNwA (ORCPT ); Wed, 14 Jan 2015 08:52:00 -0500 From: Geert Uytterhoeven To: Benjamin Herrenschmidt , Bryan Wu , Richard Purdie , Jingoo Han , Lee Jones Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 1/3] powerpc/pmac: Fix DT refcount imbalance in pmac_pic_probe_oldstyle Date: Wed, 14 Jan 2015 14:51:57 +0100 Message-Id: <1421243519-6257-2-git-send-email-geert+renesas@glider.be> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421243519-6257-1-git-send-email-geert+renesas@glider.be> References: <1421243519-6257-1-git-send-email-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_node_by_name() calls of_node_put() on its "from" parameter, which must not be done on "master", as it's still in use, and will be released manually later. This may cause a zero kref refcount. Use of_get_child_by_name() instead to fix this. Signed-off-by: Geert Uytterhoeven Cc: linuxppc-dev@lists.ozlabs.org --- Compile-tested only --- arch/powerpc/platforms/powermac/pic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c index 4c24bf60d39d2834..90ada1209c118902 100644 --- a/arch/powerpc/platforms/powermac/pic.c +++ b/arch/powerpc/platforms/powermac/pic.c @@ -321,7 +321,7 @@ static void __init pmac_pic_probe_oldstyle(void) max_irqs = max_real_irqs = 64; /* We might have a second cascaded heathrow */ - slave = of_find_node_by_name(master, "mac-io"); + slave = of_get_child_by_name(master, "mac-io"); /* Check ordering of master & slave */ if (of_device_is_compatible(master, "gatwick")) { -- 1.9.1