LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Xunlei Pang <pang.xunlei@linaro.org> To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@gmail.com>, Xunlei Pang <pang.xunlei@linaro.org> Subject: [PATCH 5/5] sched/rt: Optimize find_lowest_rq() to select a cache hot cpu Date: Mon, 19 Jan 2015 04:49:40 +0000 [thread overview] Message-ID: <1421642980-10045-5-git-send-email-pang.xunlei@linaro.org> (raw) In-Reply-To: <1421642980-10045-1-git-send-email-pang.xunlei@linaro.org> In find_lowest_rq(), if we can't find a wake_affine cpu from sched_domain, then we can actually determine a cache hot cpu instead of simply calling "cpumask_any(lowest_mask)" which always returns the first cpu in the mask. So, we can determine the cache hot cpu during the interation of sched_domain() in passing. Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org> --- kernel/sched/rt.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index d28cfa4..e6a42e6 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1535,6 +1535,7 @@ static int find_lowest_rq(struct task_struct *task) struct cpumask *lowest_mask = this_cpu_cpumask_var_ptr(local_cpu_mask); int this_cpu = smp_processor_id(); int cpu = task_cpu(task); + int cachehot_cpu = nr_cpu_ids; /* Make sure the mask is initialized first */ if (unlikely(!lowest_mask)) @@ -1566,8 +1567,12 @@ static int find_lowest_rq(struct task_struct *task) rcu_read_lock(); for_each_domain(cpu, sd) { + if (cachehot_cpu >= nr_cpu_ids) + cachehot_cpu = cpumask_first_and(lowest_mask, + sched_domain_span(sd)); + if (sd->flags & SD_WAKE_AFFINE) { - int best_cpu; + int wakeaffine_cpu; /* * "this_cpu" is cheaper to preempt than a @@ -1579,16 +1584,20 @@ static int find_lowest_rq(struct task_struct *task) return this_cpu; } - best_cpu = cpumask_first_and(lowest_mask, + wakeaffine_cpu = cpumask_first_and(lowest_mask, sched_domain_span(sd)); - if (best_cpu < nr_cpu_ids) { + if (wakeaffine_cpu < nr_cpu_ids) { rcu_read_unlock(); - return best_cpu; + return wakeaffine_cpu; } } } rcu_read_unlock(); + /* most likely cache-hot */ + if (cachehot_cpu < nr_cpu_ids) + return cachehot_cpu; + /* * And finally, if there were no matches within the domains * just give the caller *something* to work with from the compatible -- 1.9.1
next prev parent reply other threads:[~2015-01-19 4:52 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-19 4:49 [PATCH 1/5] sched/deadline: Modify cpudl::free_cpus to reflect rd->online Xunlei Pang 2015-01-19 4:49 ` [PATCH 2/5] sched/deadline: Remove cpu_active_mask from cpudl_find() Xunlei Pang 2015-01-27 15:04 ` Peter Zijlstra 2015-02-04 14:36 ` [tip:sched/core] " tip-bot for Xunlei Pang 2015-01-19 4:49 ` [PATCH 3/5] sched/deadline: Fix wrong cpudl_find() in check_preempt_equal_dl() Xunlei Pang 2015-01-27 12:48 ` Peter Zijlstra 2015-01-27 14:15 ` Peter Zijlstra 2015-01-27 16:47 ` Peter Zijlstra 2015-01-28 15:18 ` Xunlei Pang 2015-01-19 4:49 ` [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri_find() Xunlei Pang 2015-01-27 12:58 ` Peter Zijlstra 2015-01-27 14:18 ` Peter Zijlstra 2015-01-27 23:04 ` Steven Rostedt 2015-01-28 15:21 ` Xunlei Pang 2015-01-19 4:49 ` Xunlei Pang [this message] 2015-01-27 14:21 ` [PATCH 5/5] sched/rt: Optimize find_lowest_rq() to select a cache hot cpu Peter Zijlstra 2015-01-27 14:56 ` Steven Rostedt 2015-01-27 16:28 ` Peter Zijlstra 2015-01-29 16:42 ` Xunlei Pang 2015-01-29 17:17 ` Steven Rostedt 2015-01-29 19:23 ` Peter Zijlstra 2015-02-04 13:07 ` Xunlei Pang 2015-01-23 18:09 ` [PATCH 1/5] sched/deadline: Modify cpudl::free_cpus to reflect rd->online Xunlei Pang 2015-02-01 17:53 ` [tip:sched/core] sched/deadline: Modify cpudl:: free_cpus " tip-bot for Xunlei Pang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1421642980-10045-5-git-send-email-pang.xunlei@linaro.org \ --to=pang.xunlei@linaro.org \ --cc=juri.lelli@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).