LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@kernel.org>,
Alexis Berlemont <alexis.berlemont@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 15/36] perf build: Add gtk objects building
Date: Tue, 20 Jan 2015 17:39:12 +0100 [thread overview]
Message-ID: <1421771973-6022-16-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1421771973-6022-1-git-send-email-jolsa@kernel.org>
Move the gtk objects building under build framework.
Add new gtk build object so it's separated from
the rest of the code and could be librarized.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexis Berlemont <alexis.berlemont@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
---
tools/perf/Build | 2 ++
tools/perf/Makefile.perf | 17 +++++------------
tools/perf/config/Makefile | 1 +
tools/perf/ui/gtk/Build | 9 +++++++++
4 files changed, 17 insertions(+), 12 deletions(-)
create mode 100644 tools/perf/ui/gtk/Build
diff --git a/tools/perf/Build b/tools/perf/Build
index e84ced325147..a9ff8fd0bff9 100644
--- a/tools/perf/Build
+++ b/tools/perf/Build
@@ -35,3 +35,5 @@ CFLAGS_builtin-timechart.o += $(paths)
libperf-y += util/
libperf-y += arch/
libperf-y += ui/
+
+gtk-y += ui/gtk/
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 603940d5f53b..472dfd6b766f 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -341,14 +341,7 @@ endif
ifndef NO_GTK2
ALL_PROGRAMS += $(OUTPUT)libperf-gtk.so
-
- GTK_OBJS += $(OUTPUT)ui/gtk/browser.o
- GTK_OBJS += $(OUTPUT)ui/gtk/hists.o
- GTK_OBJS += $(OUTPUT)ui/gtk/setup.o
- GTK_OBJS += $(OUTPUT)ui/gtk/util.o
- GTK_OBJS += $(OUTPUT)ui/gtk/helpline.o
- GTK_OBJS += $(OUTPUT)ui/gtk/progress.o
- GTK_OBJS += $(OUTPUT)ui/gtk/annotate.o
+ GTK_IN := $(OUTPUT)gtk-in.o
install-gtk: $(OUTPUT)libperf-gtk.so
$(call QUIET_INSTALL, 'GTK UI') \
@@ -416,10 +409,10 @@ $(OUTPUT)perf: $(OUTPUT)perf.o $(BUILTIN_OBJS) $(PERFLIBS) $(PERF_IN)
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(OUTPUT)perf.o \
$(BUILTIN_OBJS) $(PERF_IN) $(LIBS) -o $@
-$(GTK_OBJS): $(OUTPUT)%.o: %.c $(LIB_H)
- $(QUIET_CC)$(CC) -o $@ -c -fPIC $(CFLAGS) $(GTK_CFLAGS) $<
+$(GTK_IN): FORCE
+ @$(MAKE) $(build)=gtk
-$(OUTPUT)libperf-gtk.so: $(GTK_OBJS) $(PERFLIBS)
+$(OUTPUT)libperf-gtk.so: $(GTK_IN) $(PERFLIBS)
$(QUIET_LINK)$(CC) -o $@ -shared $(LDFLAGS) $(filter %.o,$^) $(GTK_LIBS)
$(OUTPUT)common-cmds.h: util/generate-cmdlist.sh command-list.txt
@@ -699,7 +692,7 @@ config-clean:
@$(MAKE) -C config/feature-checks clean >/dev/null
clean: $(LIBTRACEEVENT)-clean $(LIBAPIKFS)-clean config-clean
- $(call QUIET_CLEAN, core-objs) $(RM) $(LIB_OBJS) $(BUILTIN_OBJS) $(LIB_FILE) $(OUTPUT)perf-archive $(OUTPUT)perf-with-kcore $(OUTPUT)perf.o $(LANG_BINDINGS) $(GTK_OBJS)
+ $(call QUIET_CLEAN, core-objs) $(RM) $(LIB_OBJS) $(BUILTIN_OBJS) $(LIB_FILE) $(OUTPUT)perf-archive $(OUTPUT)perf-with-kcore $(OUTPUT)perf.o $(LANG_BINDINGS)
@find . -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete
@$(RM) .config-detected
$(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 perf-read-vdsox32
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 4e5f080e2a22..05b6724fdb19 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -840,3 +840,4 @@ $(call detected_var,ETC_PERFCONFIG_SQ)
$(call detected_var,prefix_SQ)
$(call detected_var,perfexecdir_SQ)
$(call detected_var,LIBDIR)
+$(call detected_var,GTK_CFLAGS)
diff --git a/tools/perf/ui/gtk/Build b/tools/perf/ui/gtk/Build
new file mode 100644
index 000000000000..ec22e899a224
--- /dev/null
+++ b/tools/perf/ui/gtk/Build
@@ -0,0 +1,9 @@
+CFLAGS_gtk += -fPIC $(GTK_CFLAGS)
+
+gtk-y += browser.o
+gtk-y += hists.o
+gtk-y += setup.o
+gtk-y += util.o
+gtk-y += helpline.o
+gtk-y += progress.o
+gtk-y += annotate.o
--
1.9.3
next prev parent reply other threads:[~2015-01-20 17:28 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 16:38 [PATCHv3 00/36] perf tools: New build framework Jiri Olsa
2015-01-20 16:38 ` [PATCH 01/36] tools build: Add new build support Jiri Olsa
2015-01-20 16:38 ` [PATCH 02/36] tools build: Add detected config support Jiri Olsa
2015-01-20 16:39 ` [PATCH 03/36] tools build: Add subdir support Jiri Olsa
2015-01-20 16:39 ` [PATCH 04/36] perf tools: Remove api fs object from python build Jiri Olsa
2015-01-20 16:39 ` [PATCH 05/36] perf build: Disable make's built-in rules Jiri Olsa
2015-01-20 16:39 ` [PATCH 06/36] perf build: Add bench objects building Jiri Olsa
2015-01-20 16:39 ` [PATCH 07/36] perf build: Add tests " Jiri Olsa
2015-01-20 16:39 ` [PATCH 08/36] perf build: Add builtin " Jiri Olsa
2015-01-21 18:52 ` David Ahern
2015-01-21 19:12 ` Jiri Olsa
2015-01-21 19:18 ` David Ahern
2015-01-21 19:22 ` Jiri Olsa
2015-01-20 16:39 ` [PATCH 09/36] perf build: Add libperf " Jiri Olsa
2015-01-20 16:39 ` [PATCH 10/36] perf build: Add probe " Jiri Olsa
2015-01-20 16:39 ` [PATCH 11/36] perf build: Add dwarf " Jiri Olsa
2015-01-20 16:39 ` [PATCH 12/36] perf build: Add dwarf unwind " Jiri Olsa
2015-01-20 16:39 ` [PATCH 13/36] perf build: Add ui " Jiri Olsa
2015-01-20 16:39 ` [PATCH 14/36] perf build: Add slang " Jiri Olsa
2015-01-20 16:39 ` Jiri Olsa [this message]
2015-01-20 16:39 ` [PATCH 16/36] perf build: Add scripts " Jiri Olsa
2015-01-20 16:39 ` [PATCH 17/36] perf build: Add perf regs " Jiri Olsa
2015-01-20 16:39 ` [PATCH 18/36] perf build: Add zlib " Jiri Olsa
2015-01-20 16:39 ` [PATCH 19/36] perf build: Add perf.o object building Jiri Olsa
2015-01-20 16:39 ` [PATCH 20/36] perf build: Add arch x86 objects building Jiri Olsa
2015-01-21 21:17 ` David Ahern
2015-01-21 21:31 ` Jiri Olsa
2015-01-21 21:45 ` David Ahern
2015-01-22 11:32 ` Jiri Olsa
2015-01-20 16:39 ` [PATCH 21/36] perf build: Add arch arm " Jiri Olsa
2015-01-20 16:39 ` [PATCH 22/36] perf build: Add arch arm64 " Jiri Olsa
2015-01-20 16:39 ` [PATCH 23/36] perf build: Add arch powerpc " Jiri Olsa
2015-01-20 16:39 ` [PATCH 24/36] perf build: Add arch s390 " Jiri Olsa
2015-01-20 16:39 ` [PATCH 25/36] perf build: Add arch sh " Jiri Olsa
2015-01-20 16:39 ` [PATCH 26/36] perf build: Add arch sparc " Jiri Olsa
2015-01-20 16:39 ` [PATCH 27/36] perf build: Add single target build framework support Jiri Olsa
2015-01-20 16:39 ` [PATCH 28/36] perf build: Remove directory dependency rules Jiri Olsa
2015-01-20 16:39 ` [PATCH 29/36] perf build: Remove uneeded variables Jiri Olsa
2015-01-20 16:39 ` [PATCH 30/36] perf build: Remove PERF-CFLAGS file Jiri Olsa
2015-01-20 16:39 ` [PATCH 31/36] perf build: Add build documentation Jiri Olsa
2015-01-20 16:39 ` [PATCH 32/36] tools lib api: Use tools build framework Jiri Olsa
2015-01-20 16:39 ` [PATCH 33/36] tools lib api: Rename libapikfs.a to libapi.a Jiri Olsa
2015-01-20 16:39 ` [PATCH 34/36] tools lib traceevent: Use tools build framework Jiri Olsa
2015-01-20 16:39 ` [PATCH 35/36] tools lib lockdep: " Jiri Olsa
2015-01-20 16:39 ` [PATCH 36/36] perf build: Display make commands on V=1 Jiri Olsa
2015-01-20 23:02 ` [PATCHv3 00/36] perf tools: New build framework David Ahern
2015-01-21 6:14 ` Ingo Molnar
2015-01-21 12:03 ` Jiri Olsa
2015-01-21 6:13 ` Ingo Molnar
2015-01-21 12:01 ` Jiri Olsa
2015-01-21 17:25 ` Will Deacon
2015-01-26 9:21 ` Jiri Olsa
2015-01-21 23:30 ` Sukadev Bhattiprolu
2015-01-26 9:20 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2015-01-26 10:12 [PATCHv4 " Jiri Olsa
2015-01-26 10:12 ` [PATCH 15/36] perf build: Add gtk objects building Jiri Olsa
2015-01-15 12:54 [PATCHv2 00/36] perf tools: New build framework Jiri Olsa
2015-01-15 12:55 ` [PATCH 15/36] perf build: Add gtk objects building Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421771973-6022-16-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=acme@redhat.com \
--cc=alexis.berlemont@gmail.com \
--cc=bp@alien8.de \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--subject='Re: [PATCH 15/36] perf build: Add gtk objects building' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).