LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Yao <mark.yao@rock-chips.com>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Clark <robdclark@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Daniel Kurtz <djkurtz@chromium.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Cc: Mark Yao <mark.yao@rock-chips.com>
Subject: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
Date: Thu, 22 Jan 2015 18:29:55 +0800 [thread overview]
Message-ID: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com> (raw)
drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc.
but vop only have enable/disable mode, maybe case such bug:
--> DRM_DPMS_ON: power on vop
--> DRM_DPMS_SUSPEND: power off vop
--> DRM_DPMS_OFF: already power off at SUSPEND, crash
so use a bool val is more suitable.
another problem at vop_crtc_dpms:
vop_enable()->drm_vblank_on, drm_vblank_on may call vop
enable vblank. if it happen, vblank enable would failed,
then cause irq status error. because is_enabled value is set
after drm_vblank_on.
Changes in v2:
- fix mistake that set is_enabled wrong.
Mark Yao (2):
drm/rockchip: vop use is_enabled instead of dpms mode
drm/rockchip: vop: set vop enabled after enable iommu
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 +++++------------
drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 3 +--
3 files changed, 7 insertions(+), 15 deletions(-)
--
1.7.9.5
next reply other threads:[~2015-01-22 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 10:29 Mark Yao [this message]
2015-01-22 10:29 ` [PATCH v2 1/2] drm/rockchip: vop use is_enabled instead of dpms mode Mark Yao
2015-01-23 2:04 ` Daniel Kurtz
2015-01-22 10:29 ` [PATCH v2 2/2] drm/rockchip: vop: set vop enabled after enable iommu Mark Yao
2015-01-24 15:14 ` [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421922597-18351-1-git-send-email-mark.yao@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robdclark@gmail.com \
--subject='Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).