LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
Date: Fri, 23 Jan 2015 16:47:55 +0100	[thread overview]
Message-ID: <1422028075.15395.92.camel@collabora.co.uk> (raw)
In-Reply-To: <CABxcv=mJhHTBKes38+6kHi5o3RmBHHN6sVqBUDRc-YyNvkdESQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On Fri, 2015-01-23 at 15:36 +0100, Javier Martinez Canillas wrote:
> Hello Jaehoon,
> 
> On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> > Add sd0_rst node to exynos5420-pinctrl.dtsi.
> > (It's used on odroid-xu3 board)
> >
> 
> It would be good to mention which device needs this pinctrl line.
> 
> > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++
> 
> If this pin is used by the Odroid XU3 board, shouldn't be defined in
> the exynos5422-odroidxu3.dts instead?

It's not just used by the XU3 though, it's also hooked up on the peach
pi chromebook for example and i would expect it to be hooked up on most
board with an eMMC

This change is consistent with most of the special purpose GPIO pins
defined in that file, so i don't see the problem with including it in
that pinctrl file
-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]

  reply	other threads:[~2015-01-23 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 14:23 Jaehoon Chung
2015-01-23 14:36 ` Javier Martinez Canillas
2015-01-23 15:47   ` Sjoerd Simons [this message]
2015-01-23 15:59     ` Javier Martinez Canillas
2015-01-26  1:47       ` Jaehoon Chung
2015-01-23 15:50 ` Sjoerd Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422028075.15395.92.camel@collabora.co.uk \
    --to=sjoerd.simons@collabora.co.uk \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=jh80.chung@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --subject='Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).