LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
@ 2015-01-23 20:36 Priit Laes
  2015-01-23 21:22 ` Maxime Ripard
  0 siblings, 1 reply; 5+ messages in thread
From: Priit Laes @ 2015-01-23 20:36 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Maxime Ripard, devicetree, linux-arm-kernel,
	linux-kernel
  Cc: Priit Laes

Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768
IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250
accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot,
miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and
3.5mm headphone jack.
More details are available at: http://linux-sunxi.org/Gemei_G9

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 arch/arm/boot/dts/Makefile               |   6 +-
 arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 138 +++++++++++++++++++++++++++++++
 2 files changed, 142 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/boot/dts/sun4i-a10-gemei-g9.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 7df26a2..a2e05fc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -447,12 +447,14 @@ dtb-$(CONFIG_MACH_SUN4I) += \
 	sun4i-a10-ba10-tvbox.dtb \
 	sun4i-a10-chuwi-v7-cw0825.dtb \
 	sun4i-a10-cubieboard.dtb \
+	sun4i-a10-gemei-g9.dtb \
+	sun4i-a10-hackberry.dtb \
+	sun4i-a10-inet97fv2.dtb \
 	sun4i-a10-marsboard.dtb \
 	sun4i-a10-mini-xplus.dtb \
 	sun4i-a10-mk802.dtb \
 	sun4i-a10-mk802ii.dtb \
-	sun4i-a10-hackberry.dtb \
-	sun4i-a10-inet97fv2.dtb \
+	sun4i-a10-mini-xplus.dtb \
 	sun4i-a10-olinuxino-lime.dtb \
 	sun4i-a10-pcduino.dtb
 dtb-$(CONFIG_MACH_SUN5I) += \
diff --git a/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts b/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts
new file mode 100644
index 0000000..46700b8
--- /dev/null
+++ b/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts
@@ -0,0 +1,138 @@
+/*
+ * Copyright 2015 Priit Laes
+ *
+ * Priit Laes <plaes@plaes.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ *     You should have received a copy of the GNU General Public
+ *     License along with this file; if not, write to the Free
+ *     Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+ *     MA 02110-1301 USA
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun4i-a10.dtsi"
+#include "sunxi-common-regulators.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+    model = "Gemei G9 Tablet";
+    compatible = "gemei,g9", "allwinner,sun4i-a10";
+};
+
+/*
+ * http://linux-sunxi.org/Gemei_G9
+ *
+ * TODO:
+ *   2x cameras via CSI
+ *   AXP battery management
+ *   AXP power enable key
+ *   Keys (LRADC)
+ *   NAND
+ *   OTG
+ *   Touchscreen - gt801_2plus1 @ i2c adapter 2 @ 0x48
+ */
+
+
+&ehci0 {
+    status = "okay";
+};
+
+&ehci1 {
+    status = "okay";
+};
+
+&i2c0 {
+    pinctrl-names = "default";
+    pinctrl-0 = <&i2c0_pins_a>;
+    status = "okay";
+
+    axp209: pmic@34 {
+        compatible = "x-powers,axp209";
+        reg = <0x34>;
+        interrupts = <0>;
+
+        interrupt-controller;
+        #interrupt-cells = <1>;
+    };
+};
+
+&i2c1 {
+    pinctrl-names = "default";
+    pinctrl-0 = <&i2c1_pins_a>;
+    status = "okay";
+
+    /* Accelerometer */
+    bma250@18 {
+        compatible = "bosch,bma250";
+        reg = <0x18>;
+    };
+};
+
+&reg_usb1_vbus {
+    status = "okay";
+};
+
+&reg_usb2_vbus {
+    status = "okay";
+};
+
+&mmc0 {
+    pinctrl-names = "default";
+    pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>;
+    vmmc-supply = <&reg_vcc3v3>;
+    bus-width = <4>;
+    cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH01 */
+    cd-inverted;
+    status = "okay";
+};
+
+
+&uart0  {
+    pinctrl-names = "default";
+    pinctrl-0 = <&uart0_pins_a>;
+    status = "okay";
+};
+
+&usbphy {
+    usb1_vbus-supply = <&reg_usb1_vbus>;
+    usb2_vbus-supply = <&reg_usb2_vbus>;
+    status = "okay";
+};
-- 
2.2.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
  2015-01-23 20:36 [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet Priit Laes
@ 2015-01-23 21:22 ` Maxime Ripard
  2015-01-23 21:59   ` Priit Laes
  0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2015-01-23 21:22 UTC (permalink / raw)
  To: Priit Laes
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 6548 bytes --]

On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768
> IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250
> accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot,
> miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and
> 3.5mm headphone jack.
> More details are available at: http://linux-sunxi.org/Gemei_G9
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
>  arch/arm/boot/dts/Makefile               |   6 +-
>  arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 138 +++++++++++++++++++++++++++++++
>  2 files changed, 142 insertions(+), 2 deletions(-)
>  create mode 100644 arch/arm/boot/dts/sun4i-a10-gemei-g9.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7df26a2..a2e05fc 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -447,12 +447,14 @@ dtb-$(CONFIG_MACH_SUN4I) += \
>  	sun4i-a10-ba10-tvbox.dtb \
>  	sun4i-a10-chuwi-v7-cw0825.dtb \
>  	sun4i-a10-cubieboard.dtb \
> +	sun4i-a10-gemei-g9.dtb \
> +	sun4i-a10-hackberry.dtb \
> +	sun4i-a10-inet97fv2.dtb \
>  	sun4i-a10-marsboard.dtb \
>  	sun4i-a10-mini-xplus.dtb \
>  	sun4i-a10-mk802.dtb \
>  	sun4i-a10-mk802ii.dtb \
> -	sun4i-a10-hackberry.dtb \
> -	sun4i-a10-inet97fv2.dtb \
> +	sun4i-a10-mini-xplus.dtb \
>  	sun4i-a10-olinuxino-lime.dtb \
>  	sun4i-a10-pcduino.dtb
>  dtb-$(CONFIG_MACH_SUN5I) += \
> diff --git a/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts b/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts
> new file mode 100644
> index 0000000..46700b8
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts
> @@ -0,0 +1,138 @@
> +/*
> + * Copyright 2015 Priit Laes
> + *
> + * Priit Laes <plaes@plaes.org>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + *     You should have received a copy of the GNU General Public
> + *     License along with this file; if not, write to the Free
> + *     Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
> + *     MA 02110-1301 USA
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +#include "sun4i-a10.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +    model = "Gemei G9 Tablet";
> +    compatible = "gemei,g9", "allwinner,sun4i-a10";
> +};
> +
> +/*
> + * http://linux-sunxi.org/Gemei_G9

Please don't put URL in the DT. This is very likely to change in the
future, and won't be valid anymore.

> + *
> + * TODO:
> + *   2x cameras via CSI
> + *   AXP battery management
> + *   AXP power enable key
> + *   Keys (LRADC)
> + *   NAND
> + *   OTG
> + *   Touchscreen - gt801_2plus1 @ i2c adapter 2 @ 0x48
> + */
> +
> +
> +&ehci0 {
> +    status = "okay";
> +};

Indentation with one tabulation please.


> +&ehci1 {
> +    status = "okay";
> +};
> +
> +&i2c0 {
> +    pinctrl-names = "default";
> +    pinctrl-0 = <&i2c0_pins_a>;
> +    status = "okay";
> +
> +    axp209: pmic@34 {
> +        compatible = "x-powers,axp209";
> +        reg = <0x34>;
> +        interrupts = <0>;
> +
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +    };
> +};
> +
> +&i2c1 {
> +    pinctrl-names = "default";
> +    pinctrl-0 = <&i2c1_pins_a>;
> +    status = "okay";
> +
> +    /* Accelerometer */
> +    bma250@18 {
> +        compatible = "bosch,bma250";
> +        reg = <0x18>;

Is there a driver for this? It looks weird that it doesn't need more
properties than that.

> +    };
> +};
> +
> +&reg_usb1_vbus {
> +    status = "okay";
> +};
> +
> +&reg_usb2_vbus {
> +    status = "okay";
> +};
> +
> +&mmc0 {
> +    pinctrl-names = "default";
> +    pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>;
> +    vmmc-supply = <&reg_vcc3v3>;
> +    bus-width = <4>;
> +    cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH01 */
> +    cd-inverted;
> +    status = "okay";
> +};
> +
> +

Remove that extra new line.

> +&uart0  {
> +    pinctrl-names = "default";
> +    pinctrl-0 = <&uart0_pins_a>;
> +    status = "okay";
> +};
> +
> +&usbphy {
> +    usb1_vbus-supply = <&reg_usb1_vbus>;
> +    usb2_vbus-supply = <&reg_usb2_vbus>;
> +    status = "okay";
> +};
> -- 
> 2.2.2
> 

Looks good otherwise, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
  2015-01-23 21:22 ` Maxime Ripard
@ 2015-01-23 21:59   ` Priit Laes
  2015-01-24 14:39     ` Maxime Ripard
  0 siblings, 1 reply; 5+ messages in thread
From: Priit Laes @ 2015-01-23 21:59 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, linux-arm-kernel, linux-kernel


On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768 
> > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250 
> > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot, 
> > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and 
> > 3.5mm headphone jack.
> > More details are available at: http://linux-sunxi.org/Gemei_G9
> > 
[..]
> > 
> > +/ {
> > +    model = "Gemei G9 Tablet";
> > +    compatible = "gemei,g9", "allwinner,sun4i-a10";
> > +};
> > +
> > +/*
> > + * http://linux-sunxi.org/Gemei_G9
> 
> Please don't put URL in the DT. This is very likely to change in the 
> future, and won't be valid anymore.

OK! The URL in commit message is ok to stay?
> 
> > + *
> > + * TODO:
> > + *   2x cameras via CSI
> > + *   AXP battery management
> > + *   AXP power enable key
> > + *   Keys (LRADC)
> > + *   NAND
> > + *   OTG
> > + *   Touchscreen - gt801_2plus1 @ i2c adapter 2 @ 0x48
> > + */
> > +
> > +
> > +&ehci0 {
> > +    status = "okay";
> > +};
> 
> Indentation with one tabulation please.

Oops.. will do.
> 
> 
> > +&ehci1 {
> > +    status = "okay";
> > +};
> > +
> > +&i2c0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&i2c0_pins_a>;
> > +    status = "okay";
> > +
> > +    axp209: pmic@34 {
> > +        compatible = "x-powers,axp209";
> > +        reg = <0x34>;
> > +        interrupts = <0>;
> > +
> > +        interrupt-controller;
> > +        #interrupt-cells = <1>;
> > +    };
> > +};
> > +
> > +&i2c1 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&i2c1_pins_a>;
> > +    status = "okay";
> > +
> > +    /* Accelerometer */
> > +    bma250@18 {
> > +        compatible = "bosch,bma250";
> > +        reg = <0x18>;
> 
> Is there a driver for this? It looks weird that it doesn't need more 
> properties than that.

Yes, it's supported by drivers/iio/accel/bma180.c though I have to 
admit that this name is a bit misleading. (bosch-bma.c would 
better, I guess).

And I was a bit surprised that it worked out of the box too, but the 
device was present under /sys and I was able to read x, y, z and 
temperature values.

> > +    };
> > +};
> > +
> > +&reg_usb1_vbus {
> > +    status = "okay";
> > +};
> > +
> > +&reg_usb2_vbus {
> > +    status = "okay";
> > +};
> > +
> > +&mmc0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>;
> > +    vmmc-supply = <&reg_vcc3v3>;
> > +    bus-width = <4>;
> > +    cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH01 */
> > +    cd-inverted;
> > +    status = "okay";
> > +};
> > +
> > +
> 
> Remove that extra new line.

Will do.
> 
> > +&uart0  {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&uart0_pins_a>;
> > +    status = "okay";
> > +};
> > +
> > +&usbphy {
> > +    usb1_vbus-supply = <&reg_usb1_vbus>;
> > +    usb2_vbus-supply = <&reg_usb2_vbus>;
> > +    status = "okay";
> > +};
> > --
> > 2.2.2
> > 
> 
> Looks good otherwise, thanks! Maxime
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
  2015-01-23 21:59   ` Priit Laes
@ 2015-01-24 14:39     ` Maxime Ripard
  2015-01-24 15:53       ` Priit Laes
  0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2015-01-24 14:39 UTC (permalink / raw)
  To: Priit Laes
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]

Hi,

On Fri, Jan 23, 2015 at 11:59:35PM +0200, Priit Laes wrote:
> 
> On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> > On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768 
> > > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250 
> > > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot, 
> > > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and 
> > > 3.5mm headphone jack.
> > > More details are available at: http://linux-sunxi.org/Gemei_G9
> > > 
> [..]
> > > 
> > > +/ {
> > > +    model = "Gemei G9 Tablet";
> > > +    compatible = "gemei,g9", "allwinner,sun4i-a10";
> > > +};
> > > +
> > > +/*
> > > + * http://linux-sunxi.org/Gemei_G9
> > 
> > Please don't put URL in the DT. This is very likely to change in the 
> > future, and won't be valid anymore.
> 
> OK! The URL in commit message is ok to stay?

Yeah, I'm not that fond of it, but it's not that important either.

> > > +&i2c1 {
> > > +    pinctrl-names = "default";
> > > +    pinctrl-0 = <&i2c1_pins_a>;
> > > +    status = "okay";
> > > +
> > > +    /* Accelerometer */
> > > +    bma250@18 {
> > > +        compatible = "bosch,bma250";
> > > +        reg = <0x18>;
> > 
> > Is there a driver for this? It looks weird that it doesn't need more 
> > properties than that.
> 
> Yes, it's supported by drivers/iio/accel/bma180.c though I have to 
> admit that this name is a bit misleading. (bosch-bma.c would 
> better, I guess).
> 
> And I was a bit surprised that it worked out of the box too, but the 
> device was present under /sys and I was able to read x, y, z and 
> temperature values.

Cool :)

There's no interrupt wired to it then?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
  2015-01-24 14:39     ` Maxime Ripard
@ 2015-01-24 15:53       ` Priit Laes
  0 siblings, 0 replies; 5+ messages in thread
From: Priit Laes @ 2015-01-24 15:53 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, linux-arm-kernel, linux-kernel


On Sat, 2015-01-24 at 15:39 +0100, Maxime Ripard wrote:
> Hi,
> 
> On Fri, Jan 23, 2015 at 11:59:35PM +0200, Priit Laes wrote:
> > 
> > On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> > > On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > > > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 
> > > > 1024x768 IPS LCD display, stereo speakers, 1.3MP front camera 
> > > > and 5 MP
> > > > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch 
> > > > BMA250 accelerometer and RTL8188CUS USB wifi. It also has 
> > > > MicroSD slot, miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB 
> > > > host port and 3.5mm headphone jack.
> > > > More details are available at: http://linux-sunxi.org/Gemei_G9
> > > > 
> > [..]
> > > > 
> > > > +/ {
> > > > +    model = "Gemei G9 Tablet";
> > > > +    compatible = "gemei,g9", "allwinner,sun4i-a10";
> > > > +};
> > > > +
> > > > +/*
> > > > + * http://linux-sunxi.org/Gemei_G9
> > > 
> > > Please don't put URL in the DT. This is very likely to change in 
> > > the future, and won't be valid anymore.
> > 
> > OK! The URL in commit message is ok to stay?
> 
> Yeah, I'm not that fond of it, but it's not that important either.
> 
> > > > +&i2c1 {
> > > > +    pinctrl-names = "default";
> > > > +    pinctrl-0 = <&i2c1_pins_a>;
> > > > +    status = "okay";
> > > > +
> > > > +    /* Accelerometer */
> > > > +    bma250@18 {
> > > > +        compatible = "bosch,bma250";
> > > > +        reg = <0x18>;
> > > 
> > > Is there a driver for this? It looks weird that it doesn't need 
> > > more properties than that.
> > 
> > Yes, it's supported by drivers/iio/accel/bma180.c though I have to 
> > admit that this name is a bit misleading. (bosch-bma.c would
> > better, I guess).
> > 
> > And I was a bit surprised that it worked out of the box too, but 
> > the device was present under /sys and I was able to read x, y, z 
> > and temperature values.
> 
> Cool :)
> 
> There's no interrupt wired to it then?

Well, FEX file contained this:

[gsensor_para]
gsensor_used = 1
gsensor_name = "bma250"
gsensor_twi_addr = 0x18
gsensor_twi_id = 1
gsensor_int1 = port:PH00<6><1><default><default>
gsensor_int2 = port:PI10<6><1><default><default>

And according to the datasheet, this chip (bma250) has two interrupt 
pins.

Now, the bma180/250 driver works without IRQ-s, but it currently only 
supports single interrupt pin. Therefore I should at least add a 
comment about these pins and revisit this issue later.

/* TODO: check whether following interrupt pins are connected:
 *   - int1 - PH00
 *   - int2 - PI10
 */


Päikest,
Priit Laes :)




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-24 15:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 20:36 [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet Priit Laes
2015-01-23 21:22 ` Maxime Ripard
2015-01-23 21:59   ` Priit Laes
2015-01-24 14:39     ` Maxime Ripard
2015-01-24 15:53       ` Priit Laes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).