LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: llc: use correct size for sysctl timeout entries
@ 2015-01-24 1:47 Sasha Levin
2015-01-25 8:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2015-01-24 1:47 UTC (permalink / raw)
To: linux-kernel
Cc: Sasha Levin, Arnaldo Carvalho de Melo, David S. Miller,
open list:NETWORKING [GENERAL]
The timeout entries are sizeof(int) rather than sizeof(long), which
means that when they were getting read we'd also leak kernel memory
to userspace along with the timeout values.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
net/llc/sysctl_net_llc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/llc/sysctl_net_llc.c b/net/llc/sysctl_net_llc.c
index 612a5dd..799bafc 100644
--- a/net/llc/sysctl_net_llc.c
+++ b/net/llc/sysctl_net_llc.c
@@ -18,28 +18,28 @@ static struct ctl_table llc2_timeout_table[] = {
{
.procname = "ack",
.data = &sysctl_llc2_ack_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_ack_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "busy",
.data = &sysctl_llc2_busy_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_busy_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "p",
.data = &sysctl_llc2_p_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_p_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "rej",
.data = &sysctl_llc2_rej_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_rej_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: llc: use correct size for sysctl timeout entries
2015-01-24 1:47 [PATCH] net: llc: use correct size for sysctl timeout entries Sasha Levin
@ 2015-01-25 8:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-01-25 8:23 UTC (permalink / raw)
To: sasha.levin; +Cc: linux-kernel, acme, netdev
From: Sasha Levin <sasha.levin@oracle.com>
Date: Fri, 23 Jan 2015 20:47:00 -0500
> The timeout entries are sizeof(int) rather than sizeof(long), which
> means that when they were getting read we'd also leak kernel memory
> to userspace along with the timeout values.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-25 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-24 1:47 [PATCH] net: llc: use correct size for sysctl timeout entries Sasha Levin
2015-01-25 8:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).