LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: [PATCH v2 3/5] clocksource: sun5i: Remove sched_clock
Date: Mon, 26 Jan 2015 10:50:54 +0100	[thread overview]
Message-ID: <1422265856-27631-4-git-send-email-maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <1422265856-27631-1-git-send-email-maxime.ripard@free-electrons.com>

It's not possible to remove a sched_clock once it has been added, nor is it
possible to change its rate.

Since we will need to support a rate change, and that we have other
sched_clocks in the system anyway, remove it.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/clocksource/timer-sun5i.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
index 2f70ed528174..295bb5e1010c 100644
--- a/drivers/clocksource/timer-sun5i.c
+++ b/drivers/clocksource/timer-sun5i.c
@@ -130,11 +130,6 @@ static irqreturn_t sun5i_timer_interrupt(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-static u64 sun5i_timer_sched_read(void)
-{
-	return ~readl(timer_base + TIMER_CNTVAL_LO_REG(1));
-}
-
 static void __init sun5i_timer_init(struct device_node *node)
 {
 	struct reset_control *rstc;
@@ -166,7 +161,6 @@ static void __init sun5i_timer_init(struct device_node *node)
 	writel(TIMER_CTL_ENABLE | TIMER_CTL_RELOAD,
 	       timer_base + TIMER_CTL_REG(1));
 
-	sched_clock_register(sun5i_timer_sched_read, 32, rate);
 	clocksource_mmio_init(timer_base + TIMER_CNTVAL_LO_REG(1), node->name,
 			      rate, 340, 32, clocksource_mmio_readl_down);
 
-- 
2.2.2


  parent reply	other threads:[~2015-01-26  9:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  9:50 [PATCH v2 0/5] clocksource: sun5i: Support parent clock rate changes Maxime Ripard
2015-01-26  9:50 ` [PATCH v2 1/5] clocksource: sun5i: Switch to request_irq Maxime Ripard
2015-01-26  9:50 ` [PATCH v2 2/5] clocksource: sun5i: Use of_io_request_and_map Maxime Ripard
2015-01-26  9:50 ` Maxime Ripard [this message]
2015-01-26  9:50 ` [PATCH v2 4/5] clocksource: sun5i: Refactor the current code Maxime Ripard
2015-01-26  9:50 ` [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers Maxime Ripard
2015-01-26 11:22   ` Daniel Lezcano
2015-01-26 14:35     ` Maxime Ripard
2015-03-03  8:52       ` Maxime Ripard
2015-03-03 11:16         ` Daniel Lezcano
2015-03-04  9:32           ` Maxime Ripard
2015-03-04 11:43             ` Daniel Lezcano
2015-03-04 20:36       ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422265856-27631-4-git-send-email-maxime.ripard@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v2 3/5] clocksource: sun5i: Remove sched_clock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).