LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] scsi/lpfc: use remove handler as shutdown handler
@ 2015-01-26 15:18 Thadeu Lima de Souza Cascardo
  2015-02-16 19:41 ` James Smart
  0 siblings, 1 reply; 2+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2015-01-26 15:18 UTC (permalink / raw)
  To: linux-scsi
  Cc: james.smart, JBottomley, linux-kernel, Thadeu Lima de Souza Cascardo

Without a shutdown handler, some cards behave very badly after a kexec.
During probe, pending DMA writes will corrupt kernel memory, for
example.

Using the remove handler guarantees we will use a well tested path.

With this patch I applied, I managed to use kexec multiple times and
probe and SCSI scan worked every time.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
---
 drivers/scsi/lpfc/lpfc_init.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 0b2c53a..8aa804a 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -11248,6 +11248,7 @@ static struct pci_driver lpfc_driver = {
 	.id_table	= lpfc_id_table,
 	.probe		= lpfc_pci_probe_one,
 	.remove		= lpfc_pci_remove_one,
+	.shutdown	= lpfc_pci_remove_one,
 	.suspend        = lpfc_pci_suspend_one,
 	.resume		= lpfc_pci_resume_one,
 	.err_handler    = &lpfc_err_handler,
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi/lpfc: use remove handler as shutdown handler
  2015-01-26 15:18 [PATCH] scsi/lpfc: use remove handler as shutdown handler Thadeu Lima de Souza Cascardo
@ 2015-02-16 19:41 ` James Smart
  0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2015-02-16 19:41 UTC (permalink / raw)
  To: Thadeu Lima de Souza Cascardo; +Cc: linux-scsi, JBottomley, linux-kernel

Looks good.

Acked-By: James Smart  <james.smart@emulex.com>

-- james



On 1/26/2015 10:18 AM, Thadeu Lima de Souza Cascardo wrote:
> Without a shutdown handler, some cards behave very badly after a kexec.
> During probe, pending DMA writes will corrupt kernel memory, for
> example.
>
> Using the remove handler guarantees we will use a well tested path.
>
> With this patch I applied, I managed to use kexec multiple times and
> probe and SCSI scan worked every time.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
> ---
>   drivers/scsi/lpfc/lpfc_init.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 0b2c53a..8aa804a 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -11248,6 +11248,7 @@ static struct pci_driver lpfc_driver = {
>   	.id_table	= lpfc_id_table,
>   	.probe		= lpfc_pci_probe_one,
>   	.remove		= lpfc_pci_remove_one,
> +	.shutdown	= lpfc_pci_remove_one,
>   	.suspend        = lpfc_pci_suspend_one,
>   	.resume		= lpfc_pci_resume_one,
>   	.err_handler    = &lpfc_err_handler,


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-16 19:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 15:18 [PATCH] scsi/lpfc: use remove handler as shutdown handler Thadeu Lima de Souza Cascardo
2015-02-16 19:41 ` James Smart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).