LKML Archive on
help / color / mirror / Atom feed
From: Jilai Wang <>
Cc:,,, Jilai Wang <>
Subject: [PATCH] drm/msm/mdp: full mode set if crtc enable state is changed
Date: Mon, 26 Jan 2015 14:08:46 -0500	[thread overview]
Message-ID: <> (raw)

Crtc state may not reflect the current crtc state if drm_fb_helper_blank
is called to turn dpms off without turning crtc off. A full modeset in
this case to solve the problem.

Signed-off-by: Jilai Wang <>
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
index eea209e..60d0f58 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
@@ -310,6 +310,13 @@ static int mdp5_crtc_atomic_check(struct drm_crtc *crtc,
 			return -EINVAL;
+	/*
+	 * check if the crtc state matches with the current state
+	 * if not match, force a full mode set
+	 */
+	if (state->enable != mdp5_crtc->enabled)
+		state->mode_changed = true;
 	/* verify that there are not too many planes attached to crtc
 	 * and that we don't have conflicting mixer stages:
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

                 reply	other threads:[~2015-01-26 19:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] drm/msm/mdp: full mode set if crtc enable state is changed' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).