LKML Archive on
help / color / mirror / Atom feed
* [PATCH] drm/msm/mdp: full mode set if crtc enable state is changed
@ 2015-01-26 19:08 Jilai Wang
  0 siblings, 0 replies; only message in thread
From: Jilai Wang @ 2015-01-26 19:08 UTC (permalink / raw)
  To: dri-devel; +Cc: linux-arm-msm, linux-kernel, robdclark, Jilai Wang

Crtc state may not reflect the current crtc state if drm_fb_helper_blank
is called to turn dpms off without turning crtc off. A full modeset in
this case to solve the problem.

Signed-off-by: Jilai Wang <>
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
index eea209e..60d0f58 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
@@ -310,6 +310,13 @@ static int mdp5_crtc_atomic_check(struct drm_crtc *crtc,
 			return -EINVAL;
+	/*
+	 * check if the crtc state matches with the current state
+	 * if not match, force a full mode set
+	 */
+	if (state->enable != mdp5_crtc->enabled)
+		state->mode_changed = true;
 	/* verify that there are not too many planes attached to crtc
 	 * and that we don't have conflicting mixer stages:
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-26 19:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 19:08 [PATCH] drm/msm/mdp: full mode set if crtc enable state is changed Jilai Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).