LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergei Rogachev <rogachevsergei@gmail.com>
To: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com
Cc: LKML <linux-kernel@vger.kernel.org>,
	Sergei Rogachev <rogachevsergei@gmail.com>
Subject: [PATCH 1/1] mm/page_ext: remove unnecessary stack_trace field
Date: Tue, 27 Jan 2015 00:52:12 +0300	[thread overview]
Message-ID: <1422309132-28030-2-git-send-email-rogachevsergei@gmail.com> (raw)
In-Reply-To: <1422309132-28030-1-git-send-email-rogachevsergei@gmail.com>

Page owner uses the page_ext structure to keep meta-information
for every page in the system. The structure also contains a field
of type 'struct stack_trace', page owner uses this field during
invocation of the function save_stack_trace. It is easy to notice
that keeping a copy of this structure for every page in the system
is very inefficiently in terms of memory.

The patch removes this unnecessary field of page_ext and forces
page owner to use a stack_trace structure allocated on the stack.

Signed-off-by: Sergei Rogachev <rogachevsergei@gmail.com>
---
 include/linux/page_ext.h |  2 +-
 mm/page_owner.c          | 21 ++++++++++++---------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/include/linux/page_ext.h b/include/linux/page_ext.h
index d2a2c84..c42981c 100644
--- a/include/linux/page_ext.h
+++ b/include/linux/page_ext.h
@@ -40,7 +40,7 @@ struct page_ext {
 #ifdef CONFIG_PAGE_OWNER
 	unsigned int order;
 	gfp_t gfp_mask;
-	struct stack_trace trace;
+	unsigned int nr_entries;
 	unsigned long trace_entries[8];
 #endif
 };
diff --git a/mm/page_owner.c b/mm/page_owner.c
index 9ab4a9b..f7f3318 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -60,19 +60,19 @@ void __reset_page_owner(struct page *page, unsigned int order)
 void __set_page_owner(struct page *page, unsigned int order, gfp_t gfp_mask)
 {
 	struct page_ext *page_ext;
-	struct stack_trace *trace;
+	struct stack_trace trace;
 
 	page_ext = lookup_page_ext(page);
 
-	trace = &page_ext->trace;
-	trace->nr_entries = 0;
-	trace->max_entries = ARRAY_SIZE(page_ext->trace_entries);
-	trace->entries = &page_ext->trace_entries[0];
-	trace->skip = 3;
-	save_stack_trace(&page_ext->trace);
+	trace.nr_entries = 0;
+	trace.max_entries = ARRAY_SIZE(page_ext->trace_entries);
+	trace.entries = &page_ext->trace_entries[0];
+	trace.skip = 3;
+	save_stack_trace(&trace);
 
 	page_ext->order = order;
 	page_ext->gfp_mask = gfp_mask;
+	page_ext->nr_entries = trace.nr_entries;
 
 	__set_bit(PAGE_EXT_OWNER, &page_ext->flags);
 }
@@ -83,6 +83,7 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn,
 {
 	int ret;
 	int pageblock_mt, page_mt;
+	struct stack_trace trace;
 	char *kbuf;
 
 	kbuf = kmalloc(count, GFP_KERNEL);
@@ -121,8 +122,10 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn,
 	if (ret >= count)
 		goto err;
 
-	ret += snprint_stack_trace(kbuf + ret, count - ret,
-					&page_ext->trace, 0);
+	trace.nr_entries = page_ext->nr_entries;
+	trace.entries = &page_ext->trace_entries[0];
+
+	ret += snprint_stack_trace(kbuf + ret, count - ret, &trace, 0);
 	if (ret >= count)
 		goto err;
 
-- 
1.9.1


  reply	other threads:[~2015-01-26 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 21:52 [PATCH 0/1] " Sergei Rogachev
2015-01-26 21:52 ` Sergei Rogachev [this message]
2015-01-27  8:36   ` [PATCH 1/1] " Joonsoo Kim
2015-01-27 22:43   ` Andrew Morton
2015-01-28 19:08     ` Sergei Rogachev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422309132-28030-2-git-send-email-rogachevsergei@gmail.com \
    --to=rogachevsergei@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/1] mm/page_ext: remove unnecessary stack_trace field' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).