LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Michal Simek <michal.simek@xilinx.com>,
devicetree@vger.kernel.org,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Ola Jeppson <ola@adapteva.com>,
linux-gpio@vger.kernel.org, linux-usb@vger.kernel.org,
Felipe Balbi <balbi@ti.com>,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH] usb: phy-generic: Don't fail on missing gpio reset
Date: Mon, 26 Jan 2015 17:45:29 -0800 [thread overview]
Message-ID: <1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com> (raw)
A reset through a GPIO is optional. Don't fail probing when it is
missing.
Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
Hi Andreas,
does this do the trick?
Thanks,
Sören
drivers/usb/phy/phy-generic.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index dd05254241fb..a73d4c738f0b 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b/drivers/usb/phy/phy-generic.c
@@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
if (err == -EPROBE_DEFER)
return -EPROBE_DEFER;
- if (err) {
- dev_err(dev, "Error requesting RESET GPIO\n");
- return err;
- }
+ if (err)
+ nop->gpiod_reset = NULL;
nop->phy.otg = devm_kzalloc(dev, sizeof(*nop->phy.otg),
GFP_KERNEL);
--
2.2.2.1.g63c5777
next reply other threads:[~2015-01-27 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 1:45 Soren Brinkmann [this message]
2015-01-27 15:20 ` Felipe Balbi
2015-01-27 19:13 ` Sören Brinkmann
2015-01-27 19:14 ` Felipe Balbi
2015-01-27 15:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com \
--to=soren.brinkmann@xilinx.com \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ola@adapteva.com \
--cc=peter.crosthwaite@xilinx.com \
--subject='Re: [PATCH] usb: phy-generic: Don'\''t fail on missing gpio reset' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).