From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932455AbbA0Bpo (ORCPT ); Mon, 26 Jan 2015 20:45:44 -0500 Received: from mail-oi0-f44.google.com ([209.85.218.44]:44486 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932275AbbA0Bpk (ORCPT ); Mon, 26 Jan 2015 20:45:40 -0500 From: Soren Brinkmann To: =?UTF-8?q?Andreas=20F=C3=A4rber?= Cc: Michal Simek , devicetree@vger.kernel.org, Peter Crosthwaite , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ola Jeppson , linux-gpio@vger.kernel.org, linux-usb@vger.kernel.org, Felipe Balbi , Soren Brinkmann Subject: [PATCH] usb: phy-generic: Don't fail on missing gpio reset Date: Mon, 26 Jan 2015 17:45:29 -0800 Message-Id: <1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.2.2.1.g63c5777 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A reset through a GPIO is optional. Don't fail probing when it is missing. Reported-by: Andreas Färber Signed-off-by: Soren Brinkmann --- Hi Andreas, does this do the trick? Thanks, Sören drivers/usb/phy/phy-generic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index dd05254241fb..a73d4c738f0b 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop, if (err == -EPROBE_DEFER) return -EPROBE_DEFER; - if (err) { - dev_err(dev, "Error requesting RESET GPIO\n"); - return err; - } + if (err) + nop->gpiod_reset = NULL; nop->phy.otg = devm_kzalloc(dev, sizeof(*nop->phy.otg), GFP_KERNEL); -- 2.2.2.1.g63c5777