LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: John Stultz <john.stultz@linaro.org>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
	linux-kernel@vger.kernel.org,
	Greg Hackmann <ghackmann@google.com>,
	Elliott Hughes <enh@google.com>,
	Todd Poynor <toddpoynor@google.com>,
	Android Kernel Team <kernel-team@android.com>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver
Date: Tue, 27 Jan 2015 10:24:18 +0100	[thread overview]
Message-ID: <1422350658.14015.9.camel@x220> (raw)
In-Reply-To: <1421790155-3309-1-git-send-email-john.stultz@linaro.org>

On Tue, 2015-01-20 at 13:42 -0800, John Stultz wrote:
> The functionality provided by the Android alarm-dev driver
> should now be present in the timerfd interface (thanks to
> Greg Hackmann and Todd Poynor).
> 
> As of Lollipop, AOSP can make use of the timerfd if
> alarm-dev is not present (though a fixup for setting the
> rtc time if rtc0 isn't the backing for _ALARM clockids has
> been applied post-Lollipop).
> 
> Thus, we should be able to remove alarm-dev from staging.
> 
> Cc: Greg Hackmann <ghackmann@google.com>
> Cc: Elliott Hughes <enh@google.com>
> Cc: Todd Poynor <toddpoynor@google.com>
> Cc: Android Kernel Team <kernel-team@android.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: John Stultz <john.stultz@linaro.org>

This became commit 5da41e925656 ("staging: Remove the Android alarm-dev
driver") in today's linux-next (ie, next-20150127). I noticed because a
script I use to check linux-next spotted a minor problem with it.

>  drivers/staging/android/Kconfig              |   9 -

Here there should have been a line reading
   drivers/staging/android/Makefile             |   1 -  

>  drivers/staging/android/alarm-dev.c          | 446 ---------------------------
>  drivers/staging/android/android_alarm.h      |  41 ---
>  drivers/staging/android/uapi/android_alarm.h |  62 ----
>  4 files changed, 558 deletions(-)
>  delete mode 100644 drivers/staging/android/alarm-dev.c
>  delete mode 100644 drivers/staging/android/android_alarm.h
>  delete mode 100644 drivers/staging/android/uapi/android_alarm.h

Is a trivial patch to remove that Makefile line, the one that references
CONFIG_ANDROID_INTF_ALARM_DEV and alarm-dev.o, queued already?

Thanks,


Paul Bolle


  parent reply	other threads:[~2015-01-27  9:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 21:42 John Stultz
2015-01-20 21:42 ` [PATCH 2/2][RFC] staging: Remove the Android logger driver John Stultz
2015-01-20 22:01   ` Greg KH
2015-01-25 12:11   ` Greg KH
2015-01-26 20:07     ` [PATCH] " John Stultz
2015-01-27  9:28       ` Paul Bolle
2015-01-27  9:24 ` Paul Bolle [this message]
2015-01-27 15:06   ` [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver John Stultz
2015-01-27 15:22   ` [PATCH] staging: Remove logger and alarm-dev from android Makefile John Stultz
2015-01-27 17:16     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422350658.14015.9.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=enh@google.com \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toddpoynor@google.com \
    --cc=valentinrothberg@gmail.com \
    --subject='Re: [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).