LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH RESEND] ssb: Fix Sparse error in main
@ 2015-01-28  5:49 Pramod Gurav
  2015-01-28  7:13 ` Rafał Miłecki
  2015-01-29  8:18 ` [RESEND] " Kalle Valo
  0 siblings, 2 replies; 4+ messages in thread
From: Pramod Gurav @ 2015-01-28  5:49 UTC (permalink / raw)
  To: Kalle Valo, John Linville, Michael Buesch
  Cc: netdev, linux-kernel, linux-wireless, Pramod Gurav

This change fixes below sparse error:
drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
was not declared. Should it be static?

Acked-by: Michael Buesch <m@bues.ch>
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
---
 drivers/ssb/main.c |   19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 2fead38..1e180c4 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -90,25 +90,6 @@ found:
 }
 #endif /* CONFIG_SSB_PCMCIAHOST */
 
-#ifdef CONFIG_SSB_SDIOHOST
-struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func)
-{
-	struct ssb_bus *bus;
-
-	ssb_buses_lock();
-	list_for_each_entry(bus, &buses, list) {
-		if (bus->bustype == SSB_BUSTYPE_SDIO &&
-		    bus->host_sdio == func)
-			goto found;
-	}
-	bus = NULL;
-found:
-	ssb_buses_unlock();
-
-	return bus;
-}
-#endif /* CONFIG_SSB_SDIOHOST */
-
 int ssb_for_each_bus_call(unsigned long data,
 			  int (*func)(struct ssb_bus *bus, unsigned long data))
 {
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND] ssb: Fix Sparse error in main
  2015-01-28  5:49 [PATCH RESEND] ssb: Fix Sparse error in main Pramod Gurav
@ 2015-01-28  7:13 ` Rafał Miłecki
  2015-01-29  8:18 ` [RESEND] " Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2015-01-28  7:13 UTC (permalink / raw)
  To: Pramod Gurav
  Cc: Kalle Valo, John Linville, Michael Buesch, Network Development,
	Linux Kernel Mailing List, linux-wireless

On 28 January 2015 at 06:49, Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
> This change fixes below sparse error:
> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
> was not declared. Should it be static?

Seems like it was never used. Looks OK.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESEND] ssb: Fix Sparse error in main
  2015-01-28  5:49 [PATCH RESEND] ssb: Fix Sparse error in main Pramod Gurav
  2015-01-28  7:13 ` Rafał Miłecki
@ 2015-01-29  8:18 ` Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2015-01-29  8:18 UTC (permalink / raw)
  To: Pramod Gurav
  Cc: John Linville, Michael Buesch, netdev, linux-kernel,
	linux-wireless, Pramod Gurav


> This change fixes below sparse error:
> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
> was not declared. Should it be static?
> 
> Acked-by: Michael Buesch <m@bues.ch>
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH RESEND] ssb: Fix Sparse error in main
@ 2015-01-28  5:22 Pramod Gurav
  0 siblings, 0 replies; 4+ messages in thread
From: Pramod Gurav @ 2015-01-28  5:22 UTC (permalink / raw)
  To: Kalle Valo, John Linville, Michael Buesch
  Cc: netdev, linux-kernel, Pramod Gurav

This change fixes below sparse error:
drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
was not declared. Should it be static?

Acked-by: Michael Buesch <m@bues.ch>
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
---
 drivers/ssb/main.c |   19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 2fead38..1e180c4 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -90,25 +90,6 @@ found:
 }
 #endif /* CONFIG_SSB_PCMCIAHOST */
 
-#ifdef CONFIG_SSB_SDIOHOST
-struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func)
-{
-	struct ssb_bus *bus;
-
-	ssb_buses_lock();
-	list_for_each_entry(bus, &buses, list) {
-		if (bus->bustype == SSB_BUSTYPE_SDIO &&
-		    bus->host_sdio == func)
-			goto found;
-	}
-	bus = NULL;
-found:
-	ssb_buses_unlock();
-
-	return bus;
-}
-#endif /* CONFIG_SSB_SDIOHOST */
-
 int ssb_for_each_bus_call(unsigned long data,
 			  int (*func)(struct ssb_bus *bus, unsigned long data))
 {
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-29  8:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28  5:49 [PATCH RESEND] ssb: Fix Sparse error in main Pramod Gurav
2015-01-28  7:13 ` Rafał Miłecki
2015-01-29  8:18 ` [RESEND] " Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2015-01-28  5:22 [PATCH RESEND] " Pramod Gurav

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).