LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kiran Padwal <kiran.padwal21@gmail.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: gdm724x: gdm_tty: Fix for possible null pointer dereference
Date: Thu, 29 Jan 2015 19:46:10 +0100	[thread overview]
Message-ID: <1422557170-3357-1-git-send-email-rickard_strandqvist@spectrumdigital.se> (raw)

Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/gdm724x/gdm_tty.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 001348c..66b356e 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -145,7 +145,7 @@ static int gdm_tty_recv_complete(void *data,
 	struct gdm *gdm = tty_dev->gdm[index];
 
 	if (!GDM_TTY_READY(gdm)) {
-		if (complete == RECV_PACKET_PROCESS_COMPLETE)
+		if (gdm && complete == RECV_PACKET_PROCESS_COMPLETE)
 			gdm_tty_recv(gdm, gdm_tty_recv_complete);
 		return TO_HOST_PORT_CLOSE;
 	}
-- 
1.7.10.4


             reply	other threads:[~2015-01-29 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 18:46 Rickard Strandqvist [this message]
2015-02-02 16:36 ` Sudip Mukherjee
2015-02-04 17:46   ` Rickard Strandqvist
2015-02-05 12:19     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422557170-3357-1-git-send-email-rickard_strandqvist@spectrumdigital.se \
    --to=rickard_strandqvist@spectrumdigital.se \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kiran.padwal21@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] staging: gdm724x: gdm_tty: Fix for possible null pointer dereference' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).