From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754977AbbA2Smw (ORCPT ); Thu, 29 Jan 2015 13:42:52 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:51806 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbbA2Smv (ORCPT ); Thu, 29 Jan 2015 13:42:51 -0500 From: Rickard Strandqvist To: Greg Kroah-Hartman , Kiran Padwal Cc: Rickard Strandqvist , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: gdm724x: gdm_tty: Fix for possible null pointer dereference Date: Thu, 29 Jan 2015 19:46:10 +0100 Message-Id: <1422557170-3357-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/gdm724x/gdm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index 001348c..66b356e 100644 --- a/drivers/staging/gdm724x/gdm_tty.c +++ b/drivers/staging/gdm724x/gdm_tty.c @@ -145,7 +145,7 @@ static int gdm_tty_recv_complete(void *data, struct gdm *gdm = tty_dev->gdm[index]; if (!GDM_TTY_READY(gdm)) { - if (complete == RECV_PACKET_PROCESS_COMPLETE) + if (gdm && complete == RECV_PACKET_PROCESS_COMPLETE) gdm_tty_recv(gdm, gdm_tty_recv_complete); return TO_HOST_PORT_CLOSE; } -- 1.7.10.4