LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module
@ 2015-01-29 20:37 Murali Karicheri
  2015-01-29 20:37 ` [PATCH 2/2] soc: ti: knav_qmss_queue: change knav_range_setup_acc_irq to static Murali Karicheri
  2015-01-29 21:25 ` [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module santosh.shilimkar
  0 siblings, 2 replies; 3+ messages in thread
From: Murali Karicheri @ 2015-01-29 20:37 UTC (permalink / raw)
  To: ssantosh, linux-kernel, linux-arm-kernel, arnd; +Cc: Murali Karicheri

Currently configuring qmss and dma as dynamic module creates three .ko
files. knav_qmss_acc.ko and knav_qmss_queue.ko both can't be insmod
because of circular dependency. So combine these two into one module
by changing the makefile.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/soc/ti/Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/ti/Makefile b/drivers/soc/ti/Makefile
index 6bed611..135bdad 100644
--- a/drivers/soc/ti/Makefile
+++ b/drivers/soc/ti/Makefile
@@ -1,5 +1,6 @@
 #
 # TI Keystone SOC drivers
 #
-obj-$(CONFIG_KEYSTONE_NAVIGATOR_QMSS)	+= knav_qmss_queue.o knav_qmss_acc.o
+obj-$(CONFIG_KEYSTONE_NAVIGATOR_QMSS)	+= knav_qmss.o
+knav_qmss-y := knav_qmss_queue.o knav_qmss_acc.o
 obj-$(CONFIG_KEYSTONE_NAVIGATOR_DMA)	+= knav_dma.o
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] soc: ti: knav_qmss_queue: change knav_range_setup_acc_irq to static
  2015-01-29 20:37 [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module Murali Karicheri
@ 2015-01-29 20:37 ` Murali Karicheri
  2015-01-29 21:25 ` [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module santosh.shilimkar
  1 sibling, 0 replies; 3+ messages in thread
From: Murali Karicheri @ 2015-01-29 20:37 UTC (permalink / raw)
  To: ssantosh, linux-kernel, linux-arm-kernel, arnd; +Cc: Murali Karicheri

knav_range_setup_acc_irq() is used only within the file and should
be defined as static.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/soc/ti/knav_qmss_acc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c
index 6fbfde6e..ef6f69d 100644
--- a/drivers/soc/ti/knav_qmss_acc.c
+++ b/drivers/soc/ti/knav_qmss_acc.c
@@ -209,7 +209,7 @@ static irqreturn_t knav_acc_int_handler(int irq, void *_instdata)
 	return IRQ_HANDLED;
 }
 
-int knav_range_setup_acc_irq(struct knav_range_info *range,
+static int knav_range_setup_acc_irq(struct knav_range_info *range,
 				int queue, bool enabled)
 {
 	struct knav_device *kdev = range->kdev;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module
  2015-01-29 20:37 [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module Murali Karicheri
  2015-01-29 20:37 ` [PATCH 2/2] soc: ti: knav_qmss_queue: change knav_range_setup_acc_irq to static Murali Karicheri
@ 2015-01-29 21:25 ` santosh.shilimkar
  1 sibling, 0 replies; 3+ messages in thread
From: santosh.shilimkar @ 2015-01-29 21:25 UTC (permalink / raw)
  To: Murali Karicheri, ssantosh, linux-kernel, linux-arm-kernel, arnd

On 1/29/15 12:37 PM, Murali Karicheri wrote:
> Currently configuring qmss and dma as dynamic module creates three .ko
> files. knav_qmss_acc.ko and knav_qmss_queue.ko both can't be insmod
> because of circular dependency. So combine these two into one module
> by changing the makefile.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>

Applied both $subject and 2/2. Thanks

Regards,
Santosh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-29 21:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 20:37 [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module Murali Karicheri
2015-01-29 20:37 ` [PATCH 2/2] soc: ti: knav_qmss_queue: change knav_range_setup_acc_irq to static Murali Karicheri
2015-01-29 21:25 ` [PATCH 1/2] soc: ti: knav_qmss_queue: makefile tweak to build as dynamic module santosh.shilimkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).