From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965120AbbBDK1l (ORCPT ); Wed, 4 Feb 2015 05:27:41 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:9710 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933347AbbBDK1h (ORCPT ); Wed, 4 Feb 2015 05:27:37 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f126d000001e9a-43-54d1f386e0b1 Content-transfer-encoding: 8BIT From: Krzysztof Kozlowski To: Bartlomiej Zolnierkiewicz , Daniel Lezcano , Kukjin Kim , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Kyungmin Park , Krzysztof Kozlowski Subject: [PATCH] ARM: EXYNOS: cpuidle: Fix build breakage on !SMP Date: Wed, 04 Feb 2015 11:27:26 +0100 Message-id: <1423045646-20592-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNLMWRmVeSWpSXmKPExsVy+t/xq7ptny+GGDy6oWKxccZ6Vot5n2Ut Xr8wtOh//JrZ4mzTG3aLTY+vsVpc3jWHzeJz7xFGixnn9zFZrD1yl93izOlLrA7cHptWdbJ5 3Lm2h81j85J6jy1X21k8+rasYvT4vEkugC2KyyYlNSezLLVI3y6BK+PRovUsBVMFKhZ8/8rY wPiVt4uRk0NCwETi5aTFLBC2mMSFe+vZuhi5OIQEljJKPHrxiRUkwSsgKPFj8j2gIg4OZgF5 iSOXskHCzALqEpPmLWKGqO9jkng06yXYIDYBY4nNy5eADRIR2MokcfLLIhaIjl5GiZu7PUBs YQFHidMLjzKC2CwCqhIzX7ezQyxzl7h88igbxEVyEiePTWadwMg3C8kdsxDumIXkjgWMzKsY RVNLkwuKk9JzDfWKE3OLS/PS9ZLzczcxQgL8yw7GxcesDjEKcDAq8fA2tF0MEWJNLCuuzD3E KMHBrCTCW30MKMSbklhZlVqUH19UmpNafIiRiYNTqoHR6bJNyknbY1ved5R7xppejcxd8cZp JtfvefsyFZlENfJlrdtvWy03i529y9i9WO55lMMrtQuO0cW12z+96m+c8CCO+VvA9KvBaY5d 7S37BEIsP3es/8LtNf9Pd6fk2fR+U++40iqt3Qzr3dIeOSeZPJFb5Phr2ea9mwrMGzvuSIkb VJTZ2CmxFGckGmoxFxUnAgBOhQtzTgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Exynos cpuidle driver has coupled cpuidle built-in so it cannot be built without SMP: arch/arm/mach-exynos/pm.c: In function ‘exynos_cpu0_enter_aftr’: arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function ‘arch_send_wakeup_ipi_mask’ [-Werror=implicit-function-declaration] arch/arm/mach-exynos/built-in.o: In function `exynos_pre_enter_aftr': ../arch/arm/mach-exynos/pm.c:300: undefined reference to `cpu_boot_reg_base' arch/arm/mach-exynos/built-in.o: In function `exynos_cpu1_powerdown': ../arch/arm/mach-exynos/pm.c:282: undefined reference to `exynos_cpu_power_down' Make the cpuidle driver depending on SMP because this will be the fastest way to fix build break without adding a bunch of ifdefs in few places. Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-exynos/pm.c | 2 ++ drivers/cpuidle/Kconfig.arm | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c index e6209dadc00d..17db00ff7f3a 100644 --- a/arch/arm/mach-exynos/pm.c +++ b/arch/arm/mach-exynos/pm.c @@ -181,6 +181,7 @@ void exynos_enter_aftr(void) cpu_pm_exit(); } +#ifdef CONFIG_ARM_EXYNOS_CPUIDLE static atomic_t cpu1_wakeup = ATOMIC_INIT(0); static int exynos_cpu0_enter_aftr(void) @@ -302,3 +303,4 @@ struct cpuidle_exynos_data cpuidle_coupled_exynos_data = { .pre_enter_aftr = exynos_pre_enter_aftr, .post_enter_aftr = exynos_post_enter_aftr, }; +#endif /* CONFIG_ARM_EXYNOS_CPUIDLE */ diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm index 8e07c9419153..5eb86a4f74d9 100644 --- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -55,7 +55,8 @@ config ARM_AT91_CPUIDLE config ARM_EXYNOS_CPUIDLE bool "Cpu Idle Driver for the Exynos processors" depends on ARCH_EXYNOS - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP + depends on SMP + select ARCH_NEEDS_CPU_IDLE_COUPLED help Select this to enable cpuidle for Exynos processors -- 1.9.1