LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	linux-pm@vger.kernel.org, linux-shvger.kernel.org@ramsan.of.borg,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 0/2] thermal: rcar: Fix crash and restore symmetry
Date: Wed,  4 Feb 2015 13:22:33 +0100	[thread overview]
Message-ID: <1423052555-14792-1-git-send-email-geert+renesas@glider.be> (raw)

	Hi,

This series fixes an intermittent crash (NULL pointer dereference) in
the rcar-thermal driver due to a race condition, and restores symmetry
in the error and remove paths.

So far I could trigger the race condition only on r8a73a4, and only
after a soft power-on reset using the rmobile-reset driver, which is
queued for v3.20. I could not trigger it on r8a7791.
I haven't tested this on any other r8a779x, or on r8a7779.
Hence I'm not sure it's worthwhile adding this to -stable yet.

This was tested on r8a73a4/ape6evm (fixes the crash) and
r8a7791/koelsch (crash not seen).

Thanks!

Geert Uytterhoeven (2):
  thermal: rcar: Fix race condition between init and interrupt
  thermal: rcar: Restore symmetry in error and remove paths

 drivers/thermal/rcar_thermal.c | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2015-02-04 12:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 12:22 Geert Uytterhoeven [this message]
2015-02-04 12:22 ` [PATCH 1/2] thermal: rcar: Fix race condition between init and interrupt Geert Uytterhoeven
2015-02-04 12:22 ` [PATCH 2/2] thermal: rcar: Restore symmetry in error and remove paths Geert Uytterhoeven
2015-02-05  0:16 ` [PATCH 0/2] thermal: rcar: Fix crash and restore symmetry Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423052555-14792-1-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=edubezval@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-shvger.kernel.org@ramsan.of.borg \
    --cc=rui.zhang@intel.com \
    --subject='Re: [PATCH 0/2] thermal: rcar: Fix crash and restore symmetry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).