LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ext4: Fixed two coding style errors, spaces required around =
@ 2015-02-04 12:33 Oscar Forner Martinez
  2015-05-12 17:54 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Oscar Forner Martinez @ 2015-02-04 12:33 UTC (permalink / raw)
  To: linux-kernel; +Cc: tytso, adilger.kernel, linux-ext4, Oscar Forner Martinez

Two lines with assignation without spaces around the =

Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>
---
 fs/ext4/ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index f58a0d1..60fdc44 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -365,7 +365,7 @@ setversion_out:
 	}
 	case EXT4_IOC_GROUP_EXTEND: {
 		ext4_fsblk_t n_blocks_count;
-		int err, err2=0;
+		int err, err2 = 0;
 
 		err = ext4_resize_begin(sb);
 		if (err)
@@ -451,7 +451,7 @@ mext_out:
 
 	case EXT4_IOC_GROUP_ADD: {
 		struct ext4_new_group_data input;
-		int err, err2=0;
+		int err, err2 = 0;
 
 		err = ext4_resize_begin(sb);
 		if (err)
-- 
2.2.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext4: Fixed two coding style errors, spaces required around =
  2015-02-04 12:33 [PATCH] ext4: Fixed two coding style errors, spaces required around = Oscar Forner Martinez
@ 2015-05-12 17:54 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-05-12 17:54 UTC (permalink / raw)
  To: Oscar Forner Martinez; +Cc: linux-kernel, adilger.kernel, linux-ext4

On Wed, Feb 04, 2015 at 12:33:46PM +0000, Oscar Forner Martinez wrote:
> Two lines with assignation without spaces around the =
> 
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>

NACK, we don't generally take code cleanup patches unless it's part of
changes in that part of the code.  Otherwise, code cleanup patches
break other people's pending patches which are waiting code review;
and so "code cleanup" patches end up adding negative, not positive,
value.

Regards,

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-12 17:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 12:33 [PATCH] ext4: Fixed two coding style errors, spaces required around = Oscar Forner Martinez
2015-05-12 17:54 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).