LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel.h: Remove ancient __FUNCTION__ hack
Date: Wed, 04 Feb 2015 14:05:15 -0800 [thread overview]
Message-ID: <1423087515.16386.15.camel@perches.com> (raw)
In-Reply-To: <87a90twd2w.fsf@rasmusvillemoes.dk>
On Wed, 2015-02-04 at 23:01 +0100, Rasmus Villemoes wrote:
> On Wed, Feb 04 2015, Joe Perches <joe@perches.com> wrote:
>
> > On Wed, 2015-02-04 at 21:55 +0100, Rasmus Villemoes wrote:
> >> On Wed, Feb 04 2015, Joe Perches <joe@perches.com> wrote:
> >>
> >> > On Wed, 2015-02-04 at 10:48 +0100, Rasmus Villemoes wrote:
> >> >> __FUNCTION__ hasn't been treated as a string literal since gcc 3.4, so
> >> >> this only helps people who only test-compile using 3.3
> >> >> (compiler-gcc3.h barks at anything older than that). Besides, there
> >> >> are almost no occurrences of __FUNCTION__ left in the tree.
> >> >
> >> > The remaining uses of __FUNCTION__ need converting first.
> >>
> >> Why? __FUNCTION__ is recognized just fine by gcc as an alias for __func__.
> >
> > And icc and clang and ...?
>
> clang yes, icc probably (from quick googling).
Cool, but it does seem safer/more conservative to me to
convert the last 3 uses before doing this.
next prev parent reply other threads:[~2015-02-04 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 9:48 Rasmus Villemoes
2015-02-04 19:06 ` Joe Perches
2015-02-04 20:55 ` Rasmus Villemoes
2015-02-04 21:03 ` Joe Perches
2015-02-04 22:01 ` Rasmus Villemoes
2015-02-04 22:05 ` Joe Perches [this message]
2015-02-04 22:35 ` Andrew Morton
2015-02-04 22:49 ` Joe Perches
2015-02-04 23:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423087515.16386.15.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mina86@mina86.com \
--subject='Re: [PATCH] kernel.h: Remove ancient __FUNCTION__ hack' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).