From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966682AbbBDWFZ (ORCPT ); Wed, 4 Feb 2015 17:05:25 -0500 Received: from smtprelay0132.hostedemail.com ([216.40.44.132]:40363 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932669AbbBDWFV (ORCPT ); Wed, 4 Feb 2015 17:05:21 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6119:6261:7903:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: stop31_4b4decaaf202a X-Filterd-Recvd-Size: 1987 Message-ID: <1423087515.16386.15.camel@perches.com> Subject: Re: [PATCH] kernel.h: Remove ancient __FUNCTION__ hack From: Joe Perches To: Rasmus Villemoes Cc: Andrew Morton , Michal Nazarewicz , linux-kernel@vger.kernel.org Date: Wed, 04 Feb 2015 14:05:15 -0800 In-Reply-To: <87a90twd2w.fsf@rasmusvillemoes.dk> References: <1423043318-29910-1-git-send-email-linux@rasmusvillemoes.dk> <1423076787.16386.9.camel@perches.com> <87egq5wg5y.fsf@rasmusvillemoes.dk> <1423083786.16386.13.camel@perches.com> <87a90twd2w.fsf@rasmusvillemoes.dk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-02-04 at 23:01 +0100, Rasmus Villemoes wrote: > On Wed, Feb 04 2015, Joe Perches wrote: > > > On Wed, 2015-02-04 at 21:55 +0100, Rasmus Villemoes wrote: > >> On Wed, Feb 04 2015, Joe Perches wrote: > >> > >> > On Wed, 2015-02-04 at 10:48 +0100, Rasmus Villemoes wrote: > >> >> __FUNCTION__ hasn't been treated as a string literal since gcc 3.4, so > >> >> this only helps people who only test-compile using 3.3 > >> >> (compiler-gcc3.h barks at anything older than that). Besides, there > >> >> are almost no occurrences of __FUNCTION__ left in the tree. > >> > > >> > The remaining uses of __FUNCTION__ need converting first. > >> > >> Why? __FUNCTION__ is recognized just fine by gcc as an alias for __func__. > > > > And icc and clang and ...? > > clang yes, icc probably (from quick googling). Cool, but it does seem safer/more conservative to me to convert the last 3 uses before doing this.