LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: [PATCH 2/7] selftest/timers: Quiet warning due to lack of return check on brk
Date: Wed,  4 Feb 2015 22:37:07 -0800	[thread overview]
Message-ID: <1423118232-14096-3-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1423118232-14096-1-git-send-email-john.stultz@linaro.org>

The posix_timers.c test has a loop that tries to keep it in
kernel space, repeatedly calling brk(). Since its noise, and
a failure won't change what the test would do, add a unused
value to quiet the warning.

Cc: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 tools/testing/selftests/timers/posix_timers.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c
index f87d970..3e04cc0 100644
--- a/tools/testing/selftests/timers/posix_timers.c
+++ b/tools/testing/selftests/timers/posix_timers.c
@@ -35,10 +35,11 @@ static void user_loop(void)
 static void kernel_loop(void)
 {
 	void *addr = sbrk(0);
+	int unused;
 
 	while (!done) {
-		brk(addr + 4096);
-		brk(addr);
+		unused = brk(addr + 4096);
+		unused = brk(addr);
 	}
 }
 
-- 
1.9.1


  parent reply	other threads:[~2015-02-05  6:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05  6:37 [RFC][PATCH 0/7] Start adding timetests to selftest John Stultz
2015-02-05  6:37 ` [PATCH 1/7] selftests/timers: Cleanup Makefile to make it easier to add future tests John Stultz
2015-02-05  6:39   ` John Stultz
2015-02-05  6:37 ` John Stultz [this message]
2015-02-05  6:37 ` [PATCH 3/7] selftest/timers: Add nanosleep test from timetest suite John Stultz
2015-02-05  6:37 ` [PATCH 4/7] selftest/timers: Add inconsistency-check test from timetests John Stultz
2015-02-05  6:37 ` [PATCH 5/7] selftest/timers: Add nsleep-lat test from timetest suite John Stultz
2015-02-05  6:37 ` [PATCH 6/7] selftests/timers: Add clock skew estimation " John Stultz
2015-02-05  6:37 ` [PATCH 7/7] selftest/timers: Add set-timer-lat " John Stultz
2015-02-05 22:13 ` [RFC][PATCH 0/7] Start adding timetests to selftest Shuah Khan
2015-02-05 23:27   ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423118232-14096-3-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuahkh@osg.samsung.com \
    --subject='Re: [PATCH 2/7] selftest/timers: Quiet warning due to lack of return check on brk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).