LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] xen/acpi-processor: fix sparse warning
@ 2015-02-05 11:39 Lad Prabhakar
2015-02-05 19:31 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 2+ messages in thread
From: Lad Prabhakar @ 2015-02-05 11:39 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel, xen-devel
Cc: linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warning:
xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/xen/xen-acpi-processor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
index 59fc190..6c1f921 100644
--- a/drivers/xen/xen-acpi-processor.c
+++ b/drivers/xen/xen-acpi-processor.c
@@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct notifier_block *nb,
return xen_upload_processor_pm_data();
}
-struct notifier_block xen_acpi_processor_resume_nb = {
+static struct notifier_block xen_acpi_processor_resume_nb = {
.notifier_call = xen_acpi_processor_resume,
};
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/acpi-processor: fix sparse warning
2015-02-05 11:39 [PATCH] xen/acpi-processor: fix sparse warning Lad Prabhakar
@ 2015-02-05 19:31 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-02-05 19:31 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: Boris Ostrovsky, David Vrabel, xen-devel, linux-kernel
On Thu, Feb 05, 2015 at 11:39:21AM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' was not declared. Should it be static?
Not sure if it is worth fixing it - as that whole code is only
executed under normal PV guests - where it does not make
sense for it be executed.
That whole xen_resume_notifier should go away.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> Found this issue on linux-next (gcc version 4.9.2,
> sparse version 0.4.5-rc1)and applies on top linux-next.
>
> drivers/xen/xen-acpi-processor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
> index 59fc190..6c1f921 100644
> --- a/drivers/xen/xen-acpi-processor.c
> +++ b/drivers/xen/xen-acpi-processor.c
> @@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct notifier_block *nb,
> return xen_upload_processor_pm_data();
> }
>
> -struct notifier_block xen_acpi_processor_resume_nb = {
> +static struct notifier_block xen_acpi_processor_resume_nb = {
> .notifier_call = xen_acpi_processor_resume,
> };
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-05 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 11:39 [PATCH] xen/acpi-processor: fix sparse warning Lad Prabhakar
2015-02-05 19:31 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).