LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre Chevalier <pierrechevalier83@gmail.com>
To: agk@redhat.com
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Pierre Chevalier <pierrechevalier83@gmail.com>
Subject: [PATCH] drivers: md: md-thin: remove duplication with time_after
Date: Thu, 5 Feb 2015 21:58:47 +0000 [thread overview]
Message-ID: <1423173527-15157-1-git-send-email-pierrechevalier83@gmail.com> (raw)
The logic that was expressed previously was equivalent of calling
time_after.
Remove duplication.
Signed-off-by: Pierre Chevalier <pierrechevalier83@gmail.com>
---
drivers/md/dm-thin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 07705ee..c4d319b 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -11,6 +11,7 @@
#include <linux/device-mapper.h>
#include <linux/dm-io.h>
#include <linux/dm-kcopyd.h>
+#include <linux/jiffies.h>
#include <linux/log2.h>
#include <linux/list.h>
#include <linux/rculist.h>
@@ -1700,8 +1701,7 @@ static void process_cell_fail(struct thin_c *tc, struct dm_bio_prison_cell *cell
*/
static int need_commit_due_to_time(struct pool *pool)
{
- return jiffies < pool->last_commit_jiffies ||
- jiffies > pool->last_commit_jiffies + COMMIT_PERIOD;
+ return time_after(jiffies, pool->last_commit_jiffies + COMMIT_PERIOD);
}
#define thin_pbd(node) rb_entry((node), struct dm_thin_endio_hook, rb_node)
--
2.2.2
reply other threads:[~2015-02-05 21:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423173527-15157-1-git-send-email-pierrechevalier83@gmail.com \
--to=pierrechevalier83@gmail.com \
--cc=agk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--subject='Re: [PATCH] drivers: md: md-thin: remove duplication with time_after' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).