LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] nbd: Restructure debugging prints
Date: Fri, 13 Feb 2015 02:05:27 -0800	[thread overview]
Message-ID: <1423821927.2795.3.camel@perches.com> (raw)
In-Reply-To: <20150213095850.GA10654@pengutronix.de>

On Fri, 2015-02-13 at 10:58 +0100, Markus Pargmann wrote:
> On Thu, Feb 12, 2015 at 01:08:48PM -0800, Joe Perches wrote:
> > On Thu, 2015-02-12 at 21:57 +0100, Markus Pargmann wrote:
> > > dprintk has some name collisions with other frameworks and drivers. It
> > > is also not necessary to have these custom debug print filters. Dynamic
> > > debug offers the same amount of filtered debugging.
> > > 
> > > This patch replaces all dprintks with dev_dbg(). It also removes the
> > > ioctl dprintk which prints the ingoing ioctls which should be
> > > replaceable by strace or similar stuff.
> > 
> > Perhaps add
> > 
> > #define nbd_dbg(nbd, fmt, ...)					\
> > 	dev_dbg(disk_to_dev((nbd)->disk), "%s: " fmt,		\
> > 		nbd->disk->disk_name, ##__VA_ARGS__)
> 
> I am not really happy with those custom debug print macros. What do you
> think about an inline function 'nbd_to_dev' instead?

Wouldn't that change the output?
What would the output look like?

> > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> > []
> > > +static void nbd_end_request(struct nbd_device *nbd, struct request *req)
> > >  {
> > >  	int error = req->errors ? -EIO : 0;
> > >  	struct request_queue *q = req->q;
> > >  	unsigned long flags;
> > >  
> > > -	dprintk(DBG_BLKDEV, "%s: request %p: %s\n", req->rq_disk->disk_name,
> > > -			req, error ? "failed" : "done");
> > > +	dev_dbg(disk_to_dev(nbd->disk), "%s: request %p: %s\n",
> > > +		req->rq_disk->disk_name, req, error ? "failed" : "done");
> > 
> > so this becomes
> > 
> > 	nbd_dbg(nbd, "request %p: %s\n",
> > 		req, error ? "failed" : "done");
> 
> so this would be:
>  	nbd_dbg(nbd_to_dev(nbd), "request %p: %s\n",
>  		req, error ? "failed" : "done");

I don't see much value in that style,
but I don't manage the code either.


  reply	other threads:[~2015-02-13 10:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 20:57 [PATCH 0/9] nbd: cleanups Markus Pargmann
2015-02-12 20:57 ` [PATCH 1/9] Documentation: nbd: Reformat to allow more documentation Markus Pargmann
2015-02-12 20:57 ` [PATCH 2/9] Documentation: nbd: Add list of module parameters Markus Pargmann
2015-02-14 10:29   ` [Nbd] " Wouter Verhelst
2015-02-15 21:53     ` Markus Pargmann
2015-02-12 20:57 ` [PATCH 3/9] nbd: Remove kernel internal header Markus Pargmann
2015-02-14 10:30   ` [Nbd] " Wouter Verhelst
2015-02-15 21:56     ` Markus Pargmann
2015-02-12 20:57 ` [PATCH 4/9] nbd: Replace kthread_create with kthread_run Markus Pargmann
2015-02-12 20:57 ` [PATCH 5/9] nbd: Fix device bytesize type Markus Pargmann
2015-02-12 20:57 ` [PATCH 6/9] nbd: Restructure debugging prints Markus Pargmann
2015-02-12 21:08   ` Joe Perches
2015-02-13  9:58     ` Markus Pargmann
2015-02-13 10:05       ` Joe Perches [this message]
2015-02-13 11:24         ` Markus Pargmann
2015-02-13 11:48           ` Joe Perches
2015-02-15 22:20             ` Markus Pargmann
2015-02-16  0:06               ` Joe Perches
2015-02-12 20:57 ` [PATCH 7/9] nbd: Remove fixme that was already fixed Markus Pargmann
2015-02-12 20:57 ` [PATCH 8/9] nbd: Return error code directly Markus Pargmann
2015-02-12 20:57 ` [PATCH 9/9] nbd: Return error pointer directly Markus Pargmann
2015-04-02  8:11 [PULL] NBD patches for 4.1 Markus Pargmann
2015-04-02  8:11 ` [PATCH 6/9] nbd: Restructure debugging prints Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423821927.2795.3.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=nbd-general@lists.sourceforge.net \
    --subject='Re: [PATCH 6/9] nbd: Restructure debugging prints' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).