LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent
@ 2015-03-03 19:21 Fabian Frederick
  2015-03-03 20:39 ` Joe Perches
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-03-03 19:21 UTC (permalink / raw)
  To: linux-kernel; +Cc: Fabian Frederick, Dave Chinner, xfs

new_parent is only used in 0/1 context.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/xfs/xfs_inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 5a44f1c..900c3bf 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -2860,7 +2860,7 @@ xfs_rename(
 {
 	xfs_trans_t	*tp = NULL;
 	xfs_mount_t	*mp = src_dp->i_mount;
-	int		new_parent;		/* moving to a new dir */
+	bool		new_parent;		/* moving to a new dir */
 	int		src_is_directory;	/* src_name is a directory */
 	int		error;
 	xfs_bmap_free_t free_list;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent
  2015-03-03 19:21 [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent Fabian Frederick
@ 2015-03-03 20:39 ` Joe Perches
  0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-03-03 20:39 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: linux-kernel, Dave Chinner, xfs

On Tue, 2015-03-03 at 20:21 +0100, Fabian Frederick wrote:
> new_parent is only used in 0/1 context.
[]
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
[]
> @@ -2860,7 +2860,7 @@ xfs_rename(
>  {
>  	xfs_trans_t	*tp = NULL;
>  	xfs_mount_t	*mp = src_dp->i_mount;
> -	int		new_parent;		/* moving to a new dir */
> +	bool		new_parent;		/* moving to a new dir */
>  	int		src_is_directory;	/* src_name is a directory */

Could convert src_is_directory to bool too.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-03 20:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 19:21 [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent Fabian Frederick
2015-03-03 20:39 ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).