From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758102AbbCCVwX (ORCPT ); Tue, 3 Mar 2015 16:52:23 -0500 Received: from cpsmtpb-ews06.kpnxchange.com ([213.75.39.9]:61172 "EHLO cpsmtpb-ews06.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758085AbbCCVwU (ORCPT ); Tue, 3 Mar 2015 16:52:20 -0500 Message-ID: <1425419537.24292.150.camel@x220> Subject: Re: [PATCH] Add drivers for Logitech G110, G13, G15v2 and G19 From: Paul Bolle To: Ciprian Ciubotariu Cc: linux-kernel@vger.kernel.org, Jiri Kosina , linux-input@vger.kernel.org, Bruno Premont Date: Tue, 03 Mar 2015 22:52:17 +0100 In-Reply-To: <2215516.4kP1VObgmA@pink> References: <2205053.ll7fhHWnZQ@pink> <1424533803-17017-1-git-send-email-cheepeero@gmx.net> <1424539280.24292.33.camel@x220> <2215516.4kP1VObgmA@pink> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Mar 2015 21:52:18.0295 (UTC) FILETIME=[519A9870:01D055FC] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-23 at 22:47 +0200, Ciprian Ciubotariu wrote: > On Saturday 21 February 2015 18:21:20 Paul Bolle wrote: > > Apparently Alistair Buxton, Rick L Vinyard Jr, and Thomas Berger were > > involved with this code too. There's no mention of them in the commit > > explanation. They're also not CC-ed. > > The driver moved around with a lot of people contributing small changes. Some > (including myself) chose to add a MODULE_AUTHOR line, but others didn't. While > I can list all contributors from the git fork I found, I am sure I won't be > able to track those before the git fork. > > What is the appropriate follow-up? Add all contributors to MODULE_AUTHOR? > Leave them as is? Which ones should be CC'ed? It depends, I think, on what Jiri is comfortable with for the HID tree. And I can't read Jiri's mind. Personally I would add a line or two to the commit explanation detailing how this patch ended up in your tree. And CC-ing the people previously working on this patch will cost you next to nothing, so I'd do that too. Paul Bolle