LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: fix UTF-8 encoding
@ 2015-03-04 14:38 Nicolas Iooss
  2015-03-04 15:02 ` Jiri Kosina
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Iooss @ 2015-03-04 14:38 UTC (permalink / raw)
  To: trivial; +Cc: linux-kernel, Nicolas Iooss

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1136 bytes --]

Commit 41c9e95d641a ("MAINTAINERS: add Android driver entries")
introduced non-UTF8 characters in MAINTAINERS file.  This breaks tools
like grep when using an UTF-8 locale:

    $ grep -n drivers/android MAINTAINERS
    Binary file MAINTAINERS matches

Replacing the characters by their UTF-8 counterparts fixes grep.

    $ grep -n drivers/android MAINTAINERS
    733:F:      drivers/android/

This also fixes the display of
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/MAINTAINERS?id=v3.19#n713

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 42f686f2e4b2..39187c2848e5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -725,7 +725,7 @@ F:	staging/iio/trigger/iio-trig-bfin-timer.c
 
 ANDROID DRIVERS
 M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-M:	Arve Hjønnevåg <arve@android.com>
+M:	Arve Hjønnevåg <arve@android.com>
 M:	Riley Andrews <riandrews@android.com>
 T:	git git://git.kernel.org/pub/scm/linux/kernel/gregkh/staging.git
 L:	devel@driverdev.osuosl.org
-- 
2.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: fix UTF-8 encoding
  2015-03-04 14:38 [PATCH] MAINTAINERS: fix UTF-8 encoding Nicolas Iooss
@ 2015-03-04 15:02 ` Jiri Kosina
  2015-03-04 15:21   ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2015-03-04 15:02 UTC (permalink / raw)
  To: Nicolas Iooss; +Cc: linux-kernel

On Wed, 4 Mar 2015, Nicolas Iooss wrote:

> Commit 41c9e95d641a ("MAINTAINERS: add Android driver entries")
> introduced non-UTF8 characters in MAINTAINERS file.  This breaks tools
> like grep when using an UTF-8 locale:
> 
>     $ grep -n drivers/android MAINTAINERS
>     Binary file MAINTAINERS matches
> 
> Replacing the characters by their UTF-8 counterparts fixes grep.
> 
>     $ grep -n drivers/android MAINTAINERS
>     733:F:      drivers/android/
> 
> This also fixes the display of
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/MAINTAINERS?id=v3.19#n713
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42f686f2e4b2..39187c2848e5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -725,7 +725,7 @@ F:	staging/iio/trigger/iio-trig-bfin-timer.c
>  
>  ANDROID DRIVERS
>  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> -M:	Arve Hj?nnev?g <arve@android.com>
> +M:	Arve Hj??nnev??g <arve@android.com>

I don't really call that an improvement.

The patch was sent as

	Content-Type: text/plain; charset=y

'charset=y' (a) doesn't make any sense whatsoever (b) directly contradicts 
the intent of the patch.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: fix UTF-8 encoding
  2015-03-04 15:02 ` Jiri Kosina
@ 2015-03-04 15:21   ` Geert Uytterhoeven
  2015-03-04 15:32     ` Nicolas Iooss
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2015-03-04 15:21 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Nicolas Iooss, linux-kernel

On Wed, Mar 4, 2015 at 4:02 PM, Jiri Kosina <jkosina@suse.cz> wrote:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -725,7 +725,7 @@ F:        staging/iio/trigger/iio-trig-bfin-timer.c
>>
>>  ANDROID DRIVERS
>>  M:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> -M:   Arve Hj?nnev?g <arve@android.com>
>> +M:   Arve Hj??nnev??g <arve@android.com>
>
> I don't really call that an improvement.
>
> The patch was sent as
>
>         Content-Type: text/plain; charset=y
>
> 'charset=y' (a) doesn't make any sense whatsoever (b) directly contradicts
> the intent of the patch.

Just another case of user answering all git questions with "y".
Been there, done that. Will be handled in git soon
http://www.spinics.net/lists/git/msg246024.html

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: fix UTF-8 encoding
  2015-03-04 15:21   ` Geert Uytterhoeven
@ 2015-03-04 15:32     ` Nicolas Iooss
  2015-03-04 15:34       ` Jiri Kosina
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Iooss @ 2015-03-04 15:32 UTC (permalink / raw)
  To: Geert Uytterhoeven, Jiri Kosina; +Cc: linux-kernel

On 03/04/2015 11:21 PM, Geert Uytterhoeven wrote:
> On Wed, Mar 4, 2015 at 4:02 PM, Jiri Kosina <jkosina@suse.cz> wrote:
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -725,7 +725,7 @@ F:        staging/iio/trigger/iio-trig-bfin-timer.c
>>>
>>>  ANDROID DRIVERS
>>>  M:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> -M:   Arve Hj?nnev?g <arve@android.com>
>>> +M:   Arve Hj??nnev??g <arve@android.com>
>>
>> I don't really call that an improvement.
>>
>> The patch was sent as
>>
>>         Content-Type: text/plain; charset=y
>>
>> 'charset=y' (a) doesn't make any sense whatsoever (b) directly contradicts
>> the intent of the patch.
> 
> Just another case of user answering all git questions with "y".
> Been there, done that. Will be handled in git soon
> http://www.spinics.net/lists/git/msg246024.html
> 

Thanks for telling me what I did wrong.  I confirm I did what you
described, I still have the terminal open with the 2 questions git asked me:

$ git send-email --to trivial@kernel.org --cc
linux-kernel@vger.kernel.org 0001-MAINTAINERS-fix-UTF-8-encoding.patch
0001-MAINTAINERS-fix-UTF-8-encoding.patch
The following files are 8bit, but do not declare a
Content-Transfer-Encoding.
    0001-MAINTAINERS-fix-UTF-8-encoding.patch
Which 8bit encoding should I declare [UTF-8]? y
(mbox) Adding cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org> from line
'From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>'
(body) Adding cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org> from line
'Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>'

From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
To: trivial@kernel.org
Cc: linux-kernel@vger.kernel.org,
	Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Subject: [PATCH] MAINTAINERS: fix UTF-8 encoding
Date: Wed,  4 Mar 2015 22:38:47 +0800
Message-Id: <1425479927-6769-1-git-send-email-nicolas.iooss_linux@m4x.org>
X-Mailer: git-send-email 2.3.1
MIME-Version: 1.0
Content-Type: text/plain; charset=y
Content-Transfer-Encoding: 8bit

Send this email? ([y]es|[n]o|[q]uit|[a]ll): y


It is quite misleading to have both a "non-y" and a "yes/no" answer.
Now that I know this, I will try not to do the same error the next times
I send patches with both UTF-8 and iso-8859-15 characters.

Should I send the patch again with proper encoding?

Nicolas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: fix UTF-8 encoding
  2015-03-04 15:32     ` Nicolas Iooss
@ 2015-03-04 15:34       ` Jiri Kosina
  2015-03-04 15:38         ` Nicolas Iooss
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2015-03-04 15:34 UTC (permalink / raw)
  To: Nicolas Iooss; +Cc: Geert Uytterhoeven, linux-kernel

On Wed, 4 Mar 2015, Nicolas Iooss wrote:

> Should I send the patch again with proper encoding?

If you want it to be applied, then yes :)

Thanks,

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] MAINTAINERS: fix UTF-8 encoding
  2015-03-04 15:34       ` Jiri Kosina
@ 2015-03-04 15:38         ` Nicolas Iooss
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Iooss @ 2015-03-04 15:38 UTC (permalink / raw)
  To: trivial; +Cc: linux-kernel, Nicolas Iooss

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1136 bytes --]

Commit 41c9e95d641a ("MAINTAINERS: add Android driver entries")
introduced non-UTF8 characters in MAINTAINERS file.  This breaks tools
like grep when using an UTF-8 locale:

    $ grep -n drivers/android MAINTAINERS
    Binary file MAINTAINERS matches

Replacing the characters by their UTF-8 counterparts fixes grep.

    $ grep -n drivers/android MAINTAINERS
    733:F:      drivers/android/

This also fixes the display of
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/MAINTAINERS?id=v3.19#n713

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 42f686f2e4b2..39187c2848e5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -725,7 +725,7 @@ F:	staging/iio/trigger/iio-trig-bfin-timer.c
 
 ANDROID DRIVERS
 M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-M:	Arve Hjønnevåg <arve@android.com>
+M:	Arve Hjønnevåg <arve@android.com>
 M:	Riley Andrews <riandrews@android.com>
 T:	git git://git.kernel.org/pub/scm/linux/kernel/gregkh/staging.git
 L:	devel@driverdev.osuosl.org
-- 
2.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-03-04 15:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 14:38 [PATCH] MAINTAINERS: fix UTF-8 encoding Nicolas Iooss
2015-03-04 15:02 ` Jiri Kosina
2015-03-04 15:21   ` Geert Uytterhoeven
2015-03-04 15:32     ` Nicolas Iooss
2015-03-04 15:34       ` Jiri Kosina
2015-03-04 15:38         ` Nicolas Iooss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).